-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove notifications on join/leave (SQSERVICES-1634) #13431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #13431 +/- ##
==========================================
- Coverage 39.35% 39.33% -0.02%
==========================================
Files 560 560
Lines 20776 20777 +1
Branches 4425 4426 +1
==========================================
- Hits 8176 8173 -3
- Misses 11629 11631 +2
- Partials 971 973 +2 |
przemvs
approved these changes
Aug 5, 2022
aweiss-dev
added a commit
that referenced
this pull request
Aug 10, 2022
* chore: Update translations (#13400) * runfix: remove notifications on join/leave (#13431) * chore(deps): Bump crowdin/github-action from 1.4.10 to 1.4.11 (#13432) Bumps [crowdin/github-action](https://github.com/crowdin/github-action) from 1.4.10 to 1.4.11. - [Release notes](https://github.com/crowdin/github-action/releases) - [Commits](crowdin/github-action@1.4.10...1.4.11) --- updated-dependencies: - dependency-name: crowdin/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @babel/plugin-proposal-decorators (#13433) Bumps [@babel/plugin-proposal-decorators](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-proposal-decorators) from 7.18.9 to 7.18.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.18.10/packages/babel-plugin-proposal-decorators) --- updated-dependencies: - dependency-name: "@babel/plugin-proposal-decorators" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @babel/preset-env from 7.18.9 to 7.18.10 (#13434) Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.18.9 to 7.18.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.18.10/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump react-transition-group from 4.4.4 to 4.4.5 (#13435) Bumps [react-transition-group](https://github.com/reactjs/react-transition-group) from 4.4.4 to 4.4.5. - [Release notes](https://github.com/reactjs/react-transition-group/releases) - [Changelog](https://github.com/reactjs/react-transition-group/blob/master/CHANGELOG.md) - [Commits](reactjs/react-transition-group@v4.4.4...v4.4.5) --- updated-dependencies: - dependency-name: react-transition-group dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @typescript-eslint/eslint-plugin (#13438) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.31.0 to 5.32.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.32.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump jszip from 3.10.0 to 3.10.1 (#13436) Bumps [jszip](https://github.com/Stuk/jszip) from 3.10.0 to 3.10.1. - [Release notes](https://github.com/Stuk/jszip/releases) - [Changelog](https://github.com/Stuk/jszip/blob/main/CHANGES.md) - [Commits](Stuk/jszip@v3.10.0...v3.10.1) --- updated-dependencies: - dependency-name: jszip dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump eslint from 8.20.0 to 8.21.0 (#13440) Bumps [eslint](https://github.com/eslint/eslint) from 8.20.0 to 8.21.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.20.0...v8.21.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @types/react from 18.0.15 to 18.0.16 (#13441) Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.0.15 to 18.0.16. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @babel/core from 7.18.6 to 7.18.10 (#13439) Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.18.6 to 7.18.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.18.10/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @typescript-eslint/parser from 5.31.0 to 5.32.0 (#13437) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.31.0 to 5.32.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.32.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: redesign calling UI acc-80 acc-81 (#13392) * apply new design to active speaker outline * add css variables to use with call-ui components * make ButtonGroup component reactive to light and dark mode * modify fullscreen call-ui to have title-bar and controls always visible * adjust pagination to the new design * adjust ButtonGroup style * add muted icon to grid view * adjust thumbnail * add classified domain info and remote mute to title bar * apply correct focus to pagination arrow * comment out self muted label * add css variables for call buttons * change cascading order in main.less * add hover states to sidebar participants * add hover state to ButtonGroup * adjust muted info bar * add maximize label when hovering a tile * add missing active and hover status * add self mute icon on thumbnail * fix: make notifications right panel , chat participants profile pic, self deleting message menu accessible(ACC-16) (#13443) * feat: notification right panel and sef deleting message accessibility(ACC-16) change the navigation order of notification right panel integrate radio button component fix radio buttons focus state self deleting message position fix on tab fix error of self deleting context menu make context menu keyboard accessible(roving tab index) create util for context menu keyboard accessibility fix typescript errors * fix: chat participants profile picture can't get focus(ACC-16) * Update src/script/page/message-list/MessageTimerButton.tsx Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com> * fix: code review changes(ACC-16) * Update src/script/ui/ContextMenu.tsx Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com> * fix: code review changes(ACC-16) * Update src/script/view_model/panel/NotificationsPanel.tsx Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com> * fix: lint error(ACC-16) Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com> * refactor: Update new select component (#13398) * refactor: Update new select component * update select components * fix(federation): federated servers should still work when one is down (#13444) * fix: federated servers should still work when one is down * chore: update api-client types * fix(conversations): unarchive and maintain local archives (#13447) * fix: unarchive and maintain local archives * chore: update ts issues * chore: changes for PR * refactor: migrate input-bar to react (#ACC-202) (#13373) * refactor: migrate input-bar to react (#ACC-202) * Split to smaller components * betterer fix * Cr fixes and add missing functionalities * Update betterer results * cr changes * fix tests * cr fixes * cr fixes * input-bar fixes * test fixes * cr fixes * fix mentions * cr fixes * fixes * fix: input-bar reply theme colors (#13448) Co-authored-by: Otto the Bot <webapp+otto@wire.com> Co-authored-by: Timothy LeBon <tlebon@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Virgile <78490891+V-Gira@users.noreply.github.com> Co-authored-by: Arjita <arjitamitra3@gmail.com> Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com>
aweiss-dev
added a commit
that referenced
this pull request
Aug 10, 2022
* runfix: Avoid duplicated system messages for MLS groups (#13422) * fix: remove creationMessage in case we initiated the event * chore: solution didnt work * feat: filter duplicated MemberMessages in conversations * feat: add guard Co-authored-by: Adrian Weiß <github@weissadrian.com> * fix: compiler bug * feat: merge dev into edge (#13450) * chore: Update translations (#13400) * runfix: remove notifications on join/leave (#13431) * chore(deps): Bump crowdin/github-action from 1.4.10 to 1.4.11 (#13432) Bumps [crowdin/github-action](https://github.com/crowdin/github-action) from 1.4.10 to 1.4.11. - [Release notes](https://github.com/crowdin/github-action/releases) - [Commits](crowdin/github-action@1.4.10...1.4.11) --- updated-dependencies: - dependency-name: crowdin/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @babel/plugin-proposal-decorators (#13433) Bumps [@babel/plugin-proposal-decorators](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-proposal-decorators) from 7.18.9 to 7.18.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.18.10/packages/babel-plugin-proposal-decorators) --- updated-dependencies: - dependency-name: "@babel/plugin-proposal-decorators" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @babel/preset-env from 7.18.9 to 7.18.10 (#13434) Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.18.9 to 7.18.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.18.10/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump react-transition-group from 4.4.4 to 4.4.5 (#13435) Bumps [react-transition-group](https://github.com/reactjs/react-transition-group) from 4.4.4 to 4.4.5. - [Release notes](https://github.com/reactjs/react-transition-group/releases) - [Changelog](https://github.com/reactjs/react-transition-group/blob/master/CHANGELOG.md) - [Commits](reactjs/react-transition-group@v4.4.4...v4.4.5) --- updated-dependencies: - dependency-name: react-transition-group dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @typescript-eslint/eslint-plugin (#13438) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.31.0 to 5.32.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.32.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump jszip from 3.10.0 to 3.10.1 (#13436) Bumps [jszip](https://github.com/Stuk/jszip) from 3.10.0 to 3.10.1. - [Release notes](https://github.com/Stuk/jszip/releases) - [Changelog](https://github.com/Stuk/jszip/blob/main/CHANGES.md) - [Commits](Stuk/jszip@v3.10.0...v3.10.1) --- updated-dependencies: - dependency-name: jszip dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump eslint from 8.20.0 to 8.21.0 (#13440) Bumps [eslint](https://github.com/eslint/eslint) from 8.20.0 to 8.21.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.20.0...v8.21.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @types/react from 18.0.15 to 18.0.16 (#13441) Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.0.15 to 18.0.16. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @babel/core from 7.18.6 to 7.18.10 (#13439) Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.18.6 to 7.18.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.18.10/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): Bump @typescript-eslint/parser from 5.31.0 to 5.32.0 (#13437) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.31.0 to 5.32.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.32.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: redesign calling UI acc-80 acc-81 (#13392) * apply new design to active speaker outline * add css variables to use with call-ui components * make ButtonGroup component reactive to light and dark mode * modify fullscreen call-ui to have title-bar and controls always visible * adjust pagination to the new design * adjust ButtonGroup style * add muted icon to grid view * adjust thumbnail * add classified domain info and remote mute to title bar * apply correct focus to pagination arrow * comment out self muted label * add css variables for call buttons * change cascading order in main.less * add hover states to sidebar participants * add hover state to ButtonGroup * adjust muted info bar * add maximize label when hovering a tile * add missing active and hover status * add self mute icon on thumbnail * fix: make notifications right panel , chat participants profile pic, self deleting message menu accessible(ACC-16) (#13443) * feat: notification right panel and sef deleting message accessibility(ACC-16) change the navigation order of notification right panel integrate radio button component fix radio buttons focus state self deleting message position fix on tab fix error of self deleting context menu make context menu keyboard accessible(roving tab index) create util for context menu keyboard accessibility fix typescript errors * fix: chat participants profile picture can't get focus(ACC-16) * Update src/script/page/message-list/MessageTimerButton.tsx Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com> * fix: code review changes(ACC-16) * Update src/script/ui/ContextMenu.tsx Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com> * fix: code review changes(ACC-16) * Update src/script/view_model/panel/NotificationsPanel.tsx Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com> * fix: lint error(ACC-16) Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com> * refactor: Update new select component (#13398) * refactor: Update new select component * update select components * fix(federation): federated servers should still work when one is down (#13444) * fix: federated servers should still work when one is down * chore: update api-client types * fix(conversations): unarchive and maintain local archives (#13447) * fix: unarchive and maintain local archives * chore: update ts issues * chore: changes for PR * refactor: migrate input-bar to react (#ACC-202) (#13373) * refactor: migrate input-bar to react (#ACC-202) * Split to smaller components * betterer fix * Cr fixes and add missing functionalities * Update betterer results * cr changes * fix tests * cr fixes * cr fixes * input-bar fixes * test fixes * cr fixes * fix mentions * cr fixes * fixes * fix: input-bar reply theme colors (#13448) Co-authored-by: Otto the Bot <webapp+otto@wire.com> Co-authored-by: Timothy LeBon <tlebon@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Virgile <78490891+V-Gira@users.noreply.github.com> Co-authored-by: Arjita <arjitamitra3@gmail.com> Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com> Co-authored-by: Amir Ghezelbash <thisisamir98@gmail.com> Co-authored-by: Otto the Bot <webapp+otto@wire.com> Co-authored-by: Timothy LeBon <tlebon@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Virgile <78490891+V-Gira@users.noreply.github.com> Co-authored-by: Arjita <arjitamitra3@gmail.com> Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.