feat: Group Video Call #3450
Merged
feat: Group Video Call #3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add black background * Move the black background to the video calling wrapper
* new video screen buttons * buttons done * fix indentation * removed empty class
* Prepare video grid preview * Handle local video in the grid * Restore video thumbnail * Rescale videos when the grid is being rendered * added maximize overlay, removed maximize from title bar * Force initial computation of the grid * add preview of self in call ui * this is fine * Add tests on the thumbnail dispatching * Add uie names and values to grid elements * Add a comment on minimize state handling
* feat: clear inactive streams when participant connection is closed * use the getReceivers method to know which streams to remove * Refactor retrieving media stream tracks to remove
* add show switch conditions * feat: toggle device buttons * coe style fixes
Yserz
reviewed
May 25, 2018
| @@ -257,30 +254,40 @@ z.calling.entities.CallEntity = class CallEntity { | |||
|
|
|||
| /** | |||
| * Join the call. | |||
| * @returns {undefined} No return value | |||
| * @param {z.media.MediaType} [mediaType=z.media.MediaType.AUDIO] - Media type of the call | |||
There was a problem hiding this comment.
What's the reason for [mediaType=z.media.MediaType.AUDIO]?
There was a problem hiding this comment.
Oh yeah, the default value has moved to the method _joinGroupCall.
https://github.com/wireapp/wire-webapp/pull/3450/files#diff-4816db425e94bac1930aae4a710ce13bR283
You're right, we should restore the default value for this function also :)
Yserz
approved these changes
May 25, 2018
atomrc
reviewed
May 25, 2018
| data-bind="click: clickedOnShareScreen, css: {'toggled': selfStreamState.screenSend(), 'button-round-dark': !showRemoteParticipant(), 'disabled': disableToggleScreen()}" | ||
| data-uie-name="do-call-controls-toggle-screen"></div> | ||
| <!-- /ko --> | ||
| <div id="video-controls" class="video-controls" data-bind="css: {'hide-controls-hidden': !showRemoteParticipant()}"> |
There was a problem hiding this comment.
Note for later: Not sure this condition is still relevant {'hide-controls-hidden': !showRemoteParticipant()}.
atomrc
reviewed
May 25, 2018
| @@ -1031,6 +926,12 @@ z.calling.CallingRepository = class CallingRepository { | |||
| amplify.publish(z.event.WebApp.WARNING.SHOW, z.viewModel.WarningsViewModel.TYPE.UNSUPPORTED_OUTGOING_CALL); | |||
| throw new z.calling.CallError(z.calling.CallError.TYPE.NOT_SUPPORTED); | |||
| } | |||
|
|
|||
| const isVideoCall = mediaType === z.media.MediaType.AUDIO_VIDEO; | |||
There was a problem hiding this comment.
Maybe we should check all the possible type that can be considered a video.
- AUDIO_VIDEO
- VIDEO
- SCREEN
atomrc
approved these changes
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.