Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle submission errors #2

Closed
passsy opened this issue Apr 20, 2020 · 0 comments · Fixed by #72
Closed

Handle submission errors #2

passsy opened this issue Apr 20, 2020 · 0 comments · Fixed by #72
Assignees
Labels
feature request New feature or request sdk This issue affects the sdk

Comments

@passsy
Copy link
Member

passsy commented Apr 20, 2020

Right now, Wiredash doesn't handle errors during submission. It always shows the success message and leads users to believe that the submission was successful although it wasn't.

Screen-Shot-2020-04-20-12-35-22 07

Common errors are:

I could think about two stages to resolve this issue:

Solution 1: Show submission failed

Show an "error" state and allow the user to retry after resolving problems on his own (i.e. no internet).

Solution 2: Show error and automatically retry in background

Show user an error but save the feedback to disk and try to upload it at a later point automatically. (Like crashlytics)

  • After a few minutes
  • After app restart
  • After network settings change
@flschweiger flschweiger self-assigned this Apr 20, 2020
@flschweiger flschweiger added feature request New feature or request sdk This issue affects the sdk labels Apr 20, 2020
passsy added a commit that referenced this issue Feb 7, 2021
^ This is the 1st commit message:

Migrate to nnbd (manually)

everything working except for tests due to mockito

Convert more to nullsafety

More nullsafety deps

Convert to fake #1

Migrate Feedback sheet tests

Migrate feedback model test

Migrate retrying feedback submission

Migrate pending feedback item storage tests

Migrate pending feedback item storage tests #2

Migrate device info generator

Make all tests green

Update deps

Set nullsafety version

Fix analysis

Fix analysis

Switch CI to beta/dev/master

Fix NPE

Ignore dev error

Backport nnbd for old flutter versions

^ The commit message #2 will be skipped:

^ Convert more to nullsafety

^ The commit message #3 will be skipped:

^ More nullsafety deps

^ The commit message #4 will be skipped:

^ Convert to fake #1

^ The commit message #5 will be skipped:

^ Migrate Feedback sheet tests

^ The commit message #6 will be skipped:

^ Migrate feedback model test

^ The commit message #7 will be skipped:

^ Migrate retrying feedback submission

^ The commit message #8 will be skipped:

^ Migrate pending feedback item storage tests

^ The commit message #9 will be skipped:

^ Migrate pending feedback item storage tests #2

^ The commit message #10 will be skipped:

^ Migrate device info generator

^ The commit message #11 will be skipped:

^ Make all tests green

^ The commit message #12 will be skipped:

^ Update deps

^ The commit message #13 will be skipped:

^ Set nullsafety version

^ The commit message #14 will be skipped:

^ Fix analysis

^ The commit message #15 will be skipped:

^ Fix analysis

^ The commit message #16 will be skipped:

^ Switch CI to beta/dev/master

^ The commit message #17 will be skipped:

^ Fix NPE

^ The commit message #18 will be skipped:

^ Ignore dev error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request sdk This issue affects the sdk
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants