Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore '' from environment variables #323

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

passsy
Copy link
Member

@passsy passsy commented Dec 19, 2023

buildNumber, buildVersion and buildCommit can be overwritten with environment variables (https://docs.wiredash.io/sdk/custom-properties/#set-build-properties)

Unfortunately, the override also worked when the env variable returned an empty string "". This is now resolved. Empty strings will not override the true version information anymore

@passsy passsy merged commit 2e158ac into stable Dec 19, 2023
4 checks passed
@passsy passsy deleted the ignore-build-info-empty-strings branch December 19, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant