Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Guava by JDK (Partly) #2384

Merged
merged 9 commits into from
Oct 9, 2023
Merged

Replace Guava by JDK (Partly) #2384

merged 9 commits into from
Oct 9, 2023

Conversation

pks-1981
Copy link
Contributor

@pks-1981 pks-1981 commented Sep 19, 2023 •
edited
Loading

Replace Guava by JDK (Partly)
#2111

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@pks-1981 pks-1981 requested a review from a team as a code owner September 19, 2023 04:40
@pks-1981
Copy link
Contributor Author

Unfortunately, I didn't get a response in topic 2111. I’m doing it as is.

oleg-nenashev
oleg-nenashev approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO perfectly fine for a test. I am still catching up on PRs

@pks-1981
Copy link
Contributor Author

pks-1981 commented Oct 9, 2023

@oleg-nenashev Hurray) Approved)

@oleg-nenashev oleg-nenashev merged commit b868875 into wiremock:master Oct 9, 2023
7 checks passed
@oleg-nenashev oleg-nenashev added the chore Maintenance label Oct 9, 2023
@oleg-nenashev
Copy link
Member

Thanks @pks-1981 ! One less to go

@pks-1981 pks-1981 deleted the guava6 branch October 9, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@tomakehurst tomakehurst tomakehurst approved these changes

Assignees
No one assigned
Labels
chore Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pks-1981 @oleg-nenashev @tomakehurst