-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bgcolor attribute to connectors and cables #219
Conversation
Thanks for all these PRs and other submissions. I am keeping an eye on them but need to find some quiet time to properly try them out and integrate them, I cannot promise anything but it's definitely on my mind. I appreciate the work you are putting into the project! |
13f0bac
to
5673ee4
Compare
Thanks a lot for this! I tested it now locally (after figuring out how to use the github desktop app) and it works! I agree that more light colors would help, or even a way do use hex colors directly. For me, i stay now on this until its merged 😀 |
This was requested by designer2k2 in wireviz#219 for bgcolor usage. It has also been discussed in wireviz#135. The input validation is more detailed to help the user identifying and locating invalid values. The wire color padding is now done on the output to cover different input alternatives.
wow, thanks for adding the hex color option! |
Awesome stuff. Would you mind adding the relevant info to the syntax documentation I'm sure a lot of people will appreciate this new feature. |
This was requested by designer2k2 in wireviz#219 for bgcolor usage. It has also been discussed in wireviz#135. The input validation is more detailed to help the user identifying and locating invalid values. The wire color padding is now done on the output to cover different input alternatives.
This was requested by designer2k2 in wireviz#219 for bgcolor usage. It has also been discussed in wireviz#135. The input validation is more detailed to help the user identifying and locating invalid values. The wire color padding is now done on the output to cover different input alternatives.
This was requested by designer2k2 in wireviz#219 for bgcolor usage. It has also been discussed in wireviz#135. The input validation is more detailed to help the user identifying and locating invalid values. The wire color padding is now done on the output to cover different input alternatives.
IMHO, Would it be possible to adapt I see "using an obscure HTML color name as a wire color" (like If the request of solving #135 in this PR which has been waiting for too long, seems like too much effort, I have no problem performing a review now, and tackling HTML color names separately. |
This solves the wireviz#210 suggestion to render the title row of the graph nodes with this bgcolor.
Solves wireviz#210 completely by supporting bgcolor of both the node title and the whole node independently using separate attributes.
Maybe not needed that much, but mainly for consistency, to support bgcolor in all dataclasses that represent boxes in the diagram.
This was requested by designer2k2 in wireviz#219 for bgcolor usage. It has also been discussed in wireviz#135. The input validation is more detailed to help the user identifying and locating invalid values. The wire color padding is now done on the output to cover different input alternatives.
794c400
to
7d510b2
Compare
I wrote the suggestion above before implementing hex values input, that actually removes the immediate need for more colors.
I see your point, and have no problem with that. However, I also guess that some users might find it useful with a few more shades of certain colors, and have thought about how #135 could have been implemented to solve that, but it seems I don't have enough time to implement such a solution within the near future.
I wanted to rebase this branch on top of I think it's a good idea to solve #135 in a separate PR. |
OK, I understand. So to sum up
|
Thanks. The commit history of this PR was so short and clean, and contained a few little useful references that I decided not to squash. |
and the whole node independently using separate attributes (
bgcolor_title
andbgcolor
).bgcolor
of an image to enable adapting the table cell background to the image background.To make it easier choosing background colors, I suggest adding more light colors into(hex input is now possible)_color_hex
.I suggest merging both Simplify BOM code #197 and Add basic options and metadata #214 before rebasing this PR on top, and then possibly add an extra commit here before it might be ready.(done)Example usage together with other color attributes:
Click to expand YAML input