-
Notifications
You must be signed in to change notification settings - Fork 366
socket.io from v1.0.x return error on handshake #47
Comments
It's working on my stage server, not on my local server |
I get same error with socket.io 1.0.4. |
Handshake is different from |
Same issue here for 1.0.4, any workaround ? |
I also get the same issue |
Same issue here. Would be great to see an update soon |
Hi there, Thanks for using elephant.io and for opening this issue. It seems that socket.io 1.x changed a bit its payload and that elephant is currently running only for 0.x socket.io versions. We planned to take time to support it properly during july. Please be patient or submit a PR to help us before we have time to have a closer look to that. Thanks a lot |
This may help you, I posted it to stackoverflow in response to someone else with a similar issue. |
Here is a quick fix in Client.php line 331:
|
Thanks for your fix. It removes the error, since Socketio1.x doesn't allow websocket connections first. You have to connect through a polling connection, and then upgrade to websocket, if supported. However, they changed many things in the way they handle their communications, by switching to Engineio. Even if it removes the error, you won't be able to send any message. The current Elephantio implementation is meant to work with Socketio 0.9.x, and needs a huge refactoring to work with Socketio 1.x. We tried working on it but found no "quick fix", and planned refactoring the lib within a few weeks |
I made a pulling request with a quick fix. Tell me if it's good. |
Hey @guillaumepotier, what about the support planed in July ? :) |
Ahah, nice reminder @sroze ;) Like every project planning and management, we experienced some delays :) But @Taluu is starting 3.0 refacto / branch right now, and have exactly 5 working days to achieve that (after it would be me during my holidays :p) Thanks to @lalmat I think the task will be easier for us ;) Best |
Which way do you want to manage its implementation ? By using the Client's @guillaumepotier 5 working days seams great for the community ! :) |
See my comment on @lalmat's pull request : #53 (comment) The idea would be to have several "engines" which decide how to speak with the target (Socket.io 0.x, Socket.io 1.x, ... etc). |
Closing, as Elephant 3 now supports Socket.io 3.0. A "true" stable release should be available during the month. |
When enabling curl verbose during the handshake I can see that socket.io is returning an
HTTP 400
:Directly hitting the nodejs server in the browser:
http://acme.local:3700/socket.io/1
I think it's missing some parameters in the handshake query. I'm using the
master
branch. I'll try to switch to2.0.x
to see if it change something.The text was updated successfully, but these errors were encountered: