Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix metrics #17

Merged
merged 1 commit into from
Jun 17, 2021
Merged

fix metrics #17

merged 1 commit into from
Jun 17, 2021

Conversation

yiguo-wish
Copy link
Contributor

@yiguo-wish yiguo-wish commented Jun 17, 2021

panic: inconsistent label cardinality: expected 4 label values but got 3 in []string{"ListQueues", "prod", ""}
goroutine 7 [running]:
github.com/wish/qproxy/vendor/github.com/prometheus/client_golang/prometheus.

@jazhang-wish
Copy link

jazhang-wish commented Jun 17, 2021

@yiguo-wish is url being used as tag here? if so, it doesn't seem to be good since the cardinality may be large.

@yiguo-wish
Copy link
Contributor Author

yiguo-wish commented Jun 17, 2021

It should be fine, that metrics only triggers when we have malformed queue names, which is quite rare.
I'm expecting even that metrics are triggered, it should come from one url
Usually that field is queue name, but in listqueue function, we don't have that info

@yiguo-wish yiguo-wish merged commit 14706bf into main Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants