update package aws-sdk-go-v2 for a bug fix #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zengmin-wish I just landed a large cleanup of this repos layout (#3) can you (1) rebase (2) re-run dep ensure and (3) include the vendor dir changes (you'll get them now :) ) |
added 4 commits
July 3, 2019 16:44
|
there are some API change so it won't even compile. Will try to fix them but it may take a while. |
|
btw, now that we add the 'vendor' directory in the repo, changes like this one become very huge. Wondering why we add the vendor directory? We are not going to change anything in it directly, do we? |
|
I messed up this one, close it and use #4 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for https://phab.wish.com/T134608
What I did here is to run:
dep ensure -update github.com/aws/aws-sdk-go-v2and it updated Gopkg.lock. It seems it automatically removed several dependencies which I'm not sure why. I'm new to Go and its dependency management, so please let me know if there are something else I need to check/verify.
@tvi @jacksontj