Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved identifier violation #10

Closed
elfring opened this issue Sep 1, 2014 · 5 comments
Closed

reserved identifier violation #10

elfring opened this issue Sep 1, 2014 · 5 comments

Comments

@elfring
Copy link

elfring commented Sep 1, 2014

I would like to point out that identifiers like "_MEDUSA_ADDRESS_" and "__MEDUSA_VIEW_HPP__" do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

@wisk wisk added the bug label Sep 1, 2014
@wisk
Copy link
Owner

wisk commented Sep 1, 2014

Hi @elfring,

You're definitely right, at the beginning of this project, we used MEDUSA_, but now I think it's better to use the following convention: _MEDUSAHPP.
I'll to try to normalize these headers soon.

Thanks for reporting.

@elfring
Copy link
Author

elfring commented Sep 1, 2014

Would you like to reconsider the consequences of underscores in such identifiers once more?

@wisk
Copy link
Owner

wisk commented Sep 1, 2014

Ok, I agree with you, I'll update header guard convention asap.

Thanks for pointing this out. :)

@wisk wisk added coding-style and removed bug labels Sep 2, 2014
@wisk
Copy link
Owner

wisk commented Sep 2, 2014

This patch f15232d normalizes header guard naming convention.
Fell free to re-open this ticket if I missed one of them. :)

@wisk wisk closed this as completed Sep 2, 2014
@elfring
Copy link
Author

elfring commented Sep 2, 2014

Thanks for your source code improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants