-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reserved identifier violation #10
Comments
Hi @elfring, You're definitely right, at the beginning of this project, we used MEDUSA_, but now I think it's better to use the following convention: _MEDUSAHPP. Thanks for reporting. |
Would you like to reconsider the consequences of underscores in such identifiers once more? |
Ok, I agree with you, I'll update header guard convention asap. Thanks for pointing this out. :) |
This patch f15232d normalizes header guard naming convention. |
Thanks for your source code improvement. |
I would like to point out that identifiers like "
_MEDUSA_ADDRESS_
" and "__MEDUSA_VIEW_HPP__
" do not fit to the expected naming convention of the C++ language standard.Would you like to adjust your selection for unique names?
The text was updated successfully, but these errors were encountered: