Extraneous semicolon in make file for ogdf

[tlhonmey]

When building with ogdf, somewhere in the whole mess there's an extra ; getting added to the compiler flags. This causes the compile command to be split into two commands and fail with a "no input files" error. I'm apparently not familiar enough with cmake to find the source of the problem, but manually correcting the results allows the compilation to progress normally.

You'll notice the extra ; in the middle of "-fabi-version=9;-std=gnu++0x" It appears to have taken the place of a space.

OS: Gentoo Linux
cmake: 3.3.1
make: 4.1

# make --trace Makefile:692: target 'cmake_check_build_system' does not exist /usr/bin/cmake -H/root/medusa -B/root/medusa/build --check-build-system CMakeFiles/Makefile.cmake 0 Makefile:160: update target 'all' due to: cmake_check_build_system /usr/bin/cmake -E cmake_progress_start /root/medusa/build/CMakeFiles /root/medusa/build/CMakeFiles/progress.marks make -f CMakeFiles/Makefile2 all CMakeFiles/Makefile2:121: target 'deps/ogdf/CMakeFiles/coin.dir/all' does not exist make -f deps/ogdf/CMakeFiles/coin.dir/build.make deps/ogdf/CMakeFiles/coin.dir/depend deps/ogdf/CMakeFiles/coin.dir/build.make:5350: target 'deps/ogdf/CMakeFiles/coin.dir/depend' does not exist cd /root/medusa/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /root/medusa /root/medusa/deps/ogdf /root/medusa/build /root/medusa/build/deps/ogdf /root/medusa/build/deps/ogdf/CMakeFiles/coin.dir/DependInfo.cmake --color= make -f deps/ogdf/CMakeFiles/coin.dir/build.make deps/ogdf/CMakeFiles/coin.dir/build deps/ogdf/CMakeFiles/coin.dir/build.make:62: update target 'deps/ogdf/CMakeFiles/coin.dir/src/coin/Cgl/CglAllDifferent.cpp.o' due to: ../deps/ogdf/src/coin/Cgl/CglAllDifferent.cpp ../deps/ogdf/include/coin/CglAllDifferent.hpp ../deps/ogdf/include/coin/CglCutGenerator.hpp ../deps/ogdf/include/coin/CglTreeInfo.hpp ../deps/ogdf/include/coin/CoinDistance.hpp ../deps/ogdf/include/coin/CoinError.hpp ../deps/ogdf/include/coin/CoinFinite.hpp ../deps/ogdf/include/coin/CoinFloatEqual.hpp ../deps/ogdf/include/coin/CoinHelperFunctions.hpp ../deps/ogdf/include/coin/CoinMessageHandler.hpp ../deps/ogdf/include/coin/CoinPackedMatrix.hpp ../deps/ogdf/include/coin/CoinPackedVector.hpp ../deps/ogdf/include/coin/CoinPackedVectorBase.hpp ../deps/ogdf/include/coin/CoinPragma.hpp ../deps/ogdf/include/coin/CoinShallowPackedVector.hpp ../deps/ogdf/include/coin/CoinSort.hpp ../deps/ogdf/include/coin/CoinTypes.hpp ../deps/ogdf/include/coin/CoinUtilsConfig.h ../deps/ogdf/include/coin/OsiColCut.hpp ../deps/ogdf/include/coin/OsiCollections.hpp ../deps/ogdf/include/coin/OsiCut.hpp ../deps/ogdf/include/coin/OsiCuts.hpp ../deps/ogdf/include/coin/OsiRowCut.hpp ../deps/ogdf/include/coin/OsiRowCutDebugger.hpp ../deps/ogdf/include/coin/OsiSolverInterface.hpp ../deps/ogdf/include/coin/OsiSolverParameters.hpp ../deps/ogdf/include/coin/config.h ../deps/ogdf/include/coin/config_coinutils_default.h ../deps/ogdf/include/coin/config_default.h ../deps/ogdf/include/coin/config_sym_default.h ../deps/ogdf/include/coin/configall_system.h ../deps/ogdf/include/coin/configall_system_msc.h deps/ogdf/CMakeFiles/coin.dir/flags.make /usr/bin/cmake -E cmake_echo_color --switch= --green --progress-dir=/root/medusa/build/CMakeFiles --progress-num= "Building CXX object deps/ogdf/CMakeFiles/coin.dir/src/coin/Cgl/CglAllDifferent.cpp.o" [ 0%] Building CXX object deps/ogdf/CMakeFiles/coin.dir/src/coin/Cgl/CglAllDifferent.cpp.o cd /root/medusa/build/deps/ogdf && /usr/bin/c++ -DBOOST_ALL_DYN_LINK -DCLP_BUILD -DCOINUTILS_BUILD -DCOMPILE_IN_CG -DCOMPILE_IN_CP -DCOMPILE_IN_LP -DCOMPILE_IN_TM -DHAVE_CONFIG_H -DOSI_BUILD -DSYMPHONY_BUILD -DUSE_CGL_CUTS -D__OSI_CLP__ -fabi-version=9;-std=gnu++0x -fno-operator-names -I/root/medusa/deps/ogdf/include/coin -I/root/medusa/deps/ogdf/include -std=gnu++11 -o CMakeFiles/coin.dir/src/coin/Cgl/CglAllDifferent.cpp.o -c /root/medusa/deps/ogdf/src/coin/Cgl/CglAllDifferent.cpp c++: fatal error: no input files compilation terminated. /bin/sh: -std=gnu++0x: command not found deps/ogdf/CMakeFiles/coin.dir/build.make:62: recipe for target 'deps/ogdf/CMakeFiles/coin.dir/src/coin/Cgl/CglAllDifferent.cpp.o' failed make[2]: *** [deps/ogdf/CMakeFiles/coin.dir/src/coin/Cgl/CglAllDifferent.cpp.o] Error 127 CMakeFiles/Makefile2:121: recipe for target 'deps/ogdf/CMakeFiles/coin.dir/all' failed make[1]: *** [deps/ogdf/CMakeFiles/coin.dir/all] Error 2 Makefile:160: recipe for target 'all' failed make: *** [all] Error 2

[wisk]

I could be wrong but it seems this is coming from ogdf/coin CMake file. I guess I really need to use a newer version of OGDF.
Thanks for reporting.

[wisk]

Hi tlhonmey,
This issue should be fixed since we now use the latest version of OGDF.
Feel free to re-open this issue if it doesn't work.

Thank you,