Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Urgent] Duplicate any item easily with shop block #116

Closed
UnnamedWei opened this issue Dec 12, 2023 · 8 comments
Closed

[Urgent] Duplicate any item easily with shop block #116

UnnamedWei opened this issue Dec 12, 2023 · 8 comments
Labels
status: confirmed this issue is reproducible or otherwise confirmed to exist tax-evasion This issue is crashing the economy type: bug this issue breaks or otherwise adversely affects functionality

Comments

@UnnamedWei
Copy link

UnnamedWei commented Dec 12, 2023

Step 1:Owner puts something in the shop
Step 2:Another player opens the shop screen but dont close it
Step3:The Owner takes item out
Step4:Another player buys it and there you have two of that item now

This happened on my server and I have to temporarily ban all player shops, waiting for a fix, thank you very much

@UnnamedWei
Copy link
Author

Version:Fabric 1.20.1

@UnnamedWei UnnamedWei changed the title [Urgent] Duplicate any items easily with shop block [Urgent] Duplicate any item easily with shop block Dec 12, 2023
@Noaaan Noaaan added type: bug this issue breaks or otherwise adversely affects functionality tax-evasion This issue is crashing the economy priority: high this issue breaks critical functionality - it must be adressed immediately labels Dec 12, 2023
@UnnamedWei
Copy link
Author

Suggestion:

  1. Could you make it that when someone is trading the owner can’t open it or destroy it something to fix this?
  2. Can you make the creative mode shop (infinite shop block) indestructible (make it like bedrock)?
  3. Thanks a lot

@Noaaan
Copy link
Member

Noaaan commented Dec 14, 2023

For feature suggestions please open new issues, as tracking them inside an important bug report like this is not ideal.
As for your two suggestions: the first has been implemented as part of the fix as of 0e62c8a. It is scheduled for the next release.
The second suggestion is not something we are interested in implementing. Frankly, having shop blocks act as Bedrock, a completely unbreakable block, will lead to abuse where it is treated as such. Claim mods and protection mods already solve this issue.

@Noaaan Noaaan added status: confirmed this issue is reproducible or otherwise confirmed to exist status: scheduled the resolution of this issue is scheduled for the next release and removed priority: high this issue breaks critical functionality - it must be adressed immediately labels Dec 14, 2023
@UnnamedWei
Copy link
Author

Will the new release with the fix possibly clear or disable previous trades in the shop block that already exist in a server/world? Thanks

@Noaaan
Copy link
Member

Noaaan commented Dec 19, 2023

Not sure exactly what you mean by this. Do you mean removing the inventories of shop blocks? No. This is not something we would do, as it doesn't make a ton of sense, as well as leading to confusion among why items suddenly disappeared from shops.
There is nothing wrong with the trades themselves, but the logic of performing the trade, which has now been fixed.

@UnnamedWei
Copy link
Author

When will the next update be? Will there be new content added beside this fix? We really love this mod and are looking forward to it. Thanks. ☺️

@Noaaan
Copy link
Member

Noaaan commented Dec 29, 2023

Unfortunately it is a bit hard to say when exactly we have the possibility to make a release, due to being in the middle of the holiday season. Generally it will be released as soon as possible

@Noaaan Noaaan removed the status: scheduled the resolution of this issue is scheduled for the next release label Dec 31, 2023
@Noaaan
Copy link
Member

Noaaan commented Dec 31, 2023

Fixed as of 0.2.12 for 1.20.1 and 1.20.2. Thanks for reporting!

@Noaaan Noaaan closed this as completed Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed this issue is reproducible or otherwise confirmed to exist tax-evasion This issue is crashing the economy type: bug this issue breaks or otherwise adversely affects functionality
Projects
None yet
Development

No branches or pull requests

2 participants