Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slices generator should make ApplicationController inherit from SlicesController #36

Open
erino opened this issue Sep 10, 2014 · 5 comments
Milestone

Comments

@erino
Copy link
Member

erino commented Sep 10, 2014

No description provided.

@bensymonds
Copy link
Contributor

@erino (or anyone) - what's the thinking behind this? Actually I think I disagree with it. There have been a lot of cases recently where only part of the site has been Slices-backed, the rest being "normal" Rails. In those situations it would be nice to be able to have a common parent for the two parts:

          ApplicationController
               /          \
SlicesController   NormalRailsController

@jgwhite
Copy link
Contributor

jgwhite commented Sep 1, 2015

I agree with @bensymonds on this.

I would personally prefer to make SlicesController a mixin so that controllers in the host app can inherit their own ApplicationController and SlicesController. Thoughts?

@calumgunn
Copy link
Contributor

Sounds good to me. Been doing a lot of the "normal" Rails stuff and making that harder would be traumatic.

@bensymonds
Copy link
Contributor

Yeah mixin sounds good to me.

@erino
Copy link
Member Author

erino commented Sep 1, 2015

Should the mixin be automatically added to ApplicationController?

@erino erino modified the milestones: v2.0, v1.1 Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants