Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates to use the new app.render call signature #130

Merged

Conversation

asdfjkalsdfla
Copy link
Contributor

Changes

  • Updates the app.redner call to use the latest signature

Testing

  • runs the existing unit test

Copy link

changeset-bot bot commented Jan 14, 2024

🦋 Changeset detected

Latest commit: 0d67d29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@astrojs/cloudflare Minor
@astrojs/netlify Minor
@test/astro-cloudflare-dev-runtime-pages Patch
@test/astro-cloudflare-dev-runtime-workers Patch
@test/astro-cloudflare-directory-mode Patch
@test/astro-cloudflare-external-image-service Patch
@test/astro-cloudflare-function-per-route Patch
@test/astro-cloudflare-hybrid Patch
@test/astro-cloudflare-no-output Patch
@test/astro-cloudflare-prerender Patch
@test/astro-cloudflare-routes-json Patch
@test/astro-cloudflare-wasm-function-per-route Patch
@test/astro-cloudflare-wasm-directory Patch
@test/astro-cloudflare-wasm Patch
@test/astro-cloudflare-with-solid-js Patch
@test/astro-cloudflare-wrangler-runtime Patch
@test/netlify-hosted-astro-project Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexanderniebuhr
Copy link
Member

@asdfjkalsdfla Thank you for the contribution ❤️
We'll wait for some other reviews, but it should be good to go.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @asdfjkalsdfla for this contribution! @alexanderniebuhr asked me to review the changeset for our description of these changes, and so I've left a comment along with reference to what we did re: advice to users when the other adapters were updated for this internal change.

I hope this gives some helpful additional guidance here!

.changeset/curly-oranges-end.md Outdated Show resolved Hide resolved
@alexanderniebuhr alexanderniebuhr changed the title fix(cloudflare): updates to use the new app.render call signature fix: updates to use the new app.render call signature Jan 14, 2024
@alexanderniebuhr alexanderniebuhr merged commit 2b5aaa4 into withastro:main Jan 16, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants