Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves code #198

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Conversation

alexanderniebuhr
Copy link
Member

@alexanderniebuhr alexanderniebuhr commented Mar 21, 2024

Changes

  • this mainly cleans up the code
  • it also fixes the not working fallback env.ASSETS.fetch()

Testing

  • _routes.json tests are still breaking, they are addressed in a later PR from this stack

Docs

⚠️ needs v10 major doc update PR

Copy link

changeset-bot bot commented Mar 21, 2024

⚠️ No Changeset found

Latest commit: 3d59727

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexanderniebuhr
Copy link
Member Author

alexanderniebuhr commented Mar 21, 2024

@alexanderniebuhr alexanderniebuhr changed the title improves entrypoint improves code Mar 21, 2024
@alexanderniebuhr alexanderniebuhr force-pushed the v10/improves-code branch 2 times, most recently from 52abd09 to 5efdbb4 Compare March 25, 2024 06:22
@alexanderniebuhr alexanderniebuhr marked this pull request as ready for review March 25, 2024 07:03
Base automatically changed from v10/removes-esbuild to nbhr/feat_cloudflare_major March 26, 2024 10:07
@alexanderniebuhr alexanderniebuhr merged commit b6caae1 into nbhr/feat_cloudflare_major Mar 26, 2024
4 of 8 checks passed
@alexanderniebuhr alexanderniebuhr deleted the v10/improves-code branch March 26, 2024 10:32
alexanderniebuhr added a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants