Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes esbuild step #197

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

alexanderniebuhr
Copy link
Member

@alexanderniebuhr alexanderniebuhr commented Mar 21, 2024

Changes

  • removes the additional esbuild build step we had
  • this allows to use the same build output from Astro's vite astro build for Cloudflare, than any other adapter
  • only difference that we set vite.ssr.noExternal = true;, because Cloudflare doesn't have the concept of a filessystem, therefore won't be able to have a node_modules folder
  • this will lead to a ./dist/_worker.js/ output directory, which is recommended by Cloudflare for framework authors and allows use to use lazy loading of pages in Cloudflare, if our output is build that way

Testing

  • fixed some tests
  • ignored failing tests :re _routes.json generation, since the generation logic is overhauled in a following PR

Docs

⚠️ needs v10 major doc update PR

Copy link

changeset-bot bot commented Mar 21, 2024

⚠️ No Changeset found

Latest commit: e9c4f97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexanderniebuhr
Copy link
Member Author

alexanderniebuhr commented Mar 21, 2024

@alexanderniebuhr alexanderniebuhr force-pushed the v10/removes-esbuild branch 2 times, most recently from a2823d3 to 985bdaa Compare March 25, 2024 06:33
@alexanderniebuhr alexanderniebuhr marked this pull request as ready for review March 25, 2024 06:37
packages/cloudflare/src/index.ts Outdated Show resolved Hide resolved
@alexanderniebuhr alexanderniebuhr force-pushed the v10/inits-getPlatformProxy branch 2 times, most recently from a5fa48e to 803ff97 Compare March 26, 2024 08:34
Base automatically changed from v10/inits-getPlatformProxy to nbhr/feat_cloudflare_major March 26, 2024 09:54
@alexanderniebuhr alexanderniebuhr merged commit 7ea353e into nbhr/feat_cloudflare_major Mar 26, 2024
4 of 8 checks passed
@alexanderniebuhr alexanderniebuhr deleted the v10/removes-esbuild branch March 26, 2024 10:07
alexanderniebuhr added a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants