Adjust timeout for showcase screenshots #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremyfrank is attempting to deploy a commit to the Astro Team on Vercel. A member of the Team first needs to authorize it. |
delucis
approved these changes
Jun 28, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds the timeout option to the
requestIdleCallbackwhen getting screenshots for showcase sites.Background:
After opening #1157, I added a site to withastro/roadmap#521 (comment), then ran the update-showcase script locally to see things run. The script timed out on the new site, due to requestIdleCallback not resolving. This probably has something to do with animations running on load and an idle state never being reached for this particular site.