-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-astro
: Add fallback values when registry fails to fetch package version
#10255
Conversation
…rent package version
🦋 Changeset detectedLatest commit: baf38a6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-astro
]: Add fallback values when registry fails to fetch package versioncreate-astro
: Add fallback values when registry fails to fetch package version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just a little question about the fixture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating it. This looks great!
Changes
package.json
ended up having"@astrojs/check": "^undefined"
and"typescript": "^undefined"
in the dependenciesprocess.env.ASTRO_VERSION
,process.env.ASTRO_CHECK_VERSION
, andprocess.env.TYPESCRIPT_VERSION
.latest
when a network version check fails, we use the most recent version (at build-time) of workspace packages as a fallback. Since we already use the^
operator, this will result in more stable behavior thanlatest
.Testing
Updates the TypeScript logic test to check that there are no
undefined
values inpackage.json
. Not testing the exact version value since that isn't a stable value.Docs
N/A, bug fix.