create-astro: Add fallback values when registry fails to fetch package version
#10255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent package version
🦋 Changeset detectedLatest commit: baf38a6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
natemoo-re
changed the title
create-astro]: Add fallback values when registry fails to fetch package versioncreate-astro: Add fallback values when registry fails to fetch package version
github-actions
bot
added
the
pkg: create-astro
bluwy
reviewed
Feb 28, 2024
bluwy
approved these changes
Feb 29, 2024
florian-lefebvre
approved these changes
Feb 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
package.jsonended up having"@astrojs/check": "^undefined"and"typescript": "^undefined"in the dependenciesprocess.env.ASTRO_VERSION,process.env.ASTRO_CHECK_VERSION, andprocess.env.TYPESCRIPT_VERSION.latestwhen a network version check fails, we use the most recent version (at build-time) of workspace packages as a fallback. Since we already use the^operator, this will result in more stable behavior thanlatest.Testing
Updates the TypeScript logic test to check that there are no
undefinedvalues inpackage.json. Not testing the exact version value since that isn't a stable value.Docs
N/A, bug fix.