Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor bin entrypoint, add stackblitz support #1029

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

FredKSchott
Copy link
Member

Changes

Testing

  • Covered by existing tests
  • Tested manually on Node 14.x, 12.10, 12.22, and 10.x

Docs

  • Not needed

@vercel
Copy link

vercel bot commented Aug 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

astro-www – ./www

🔍 Inspect: https://vercel.com/pikapkg/astro-www/CkeS3RZVHMFEwKGBBMB5ohuXEoZH
✅ Preview: https://astro-www-git-stackblitz-support-pikapkg.vercel.app

astro-docs – ./docs

🔍 Inspect: https://vercel.com/pikapkg/astro-docs/89qwmByztpHcHyyrmDLgJkzU2H1H
✅ Preview: https://astro-docs-git-stackblitz-support-pikapkg.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2021

🦋 Changeset detected

Latest commit: a80a39c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aFuzzyBear
Copy link
Contributor

Hi Fred, am I right in presumming that this fix needs to be waited for on stackblitz before it works? or should this work from now on? really happy that you have managed to take over and have this seen to completion, I think this would be brilliant for demonstrating the examples repo's

@FredKSchott
Copy link
Member Author

Once this is released, stackblitz should at least run! There might be other bugs though so no promises that it will run successfully, but this solves the first blocker that we were running into.

@matthewp
Copy link
Contributor

matthewp commented Aug 5, 2021

lgtm

@FredKSchott FredKSchott merged commit 6ec7968 into main Aug 5, 2021
@FredKSchott FredKSchott deleted the stackblitz-support branch August 5, 2021 18:24
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants