Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: stop warning about headers usage on prerendered routes #11111

Merged
merged 2 commits into from
May 21, 2024

Conversation

bholmesdev
Copy link
Contributor

Changes

Fixes unexpected warning that headers were accessed on prerendered routes:
image

  • Short circuit on GET requests
  • Add warning when getActionResult() is used for POST requests with a null body

Testing

Manual testing that the log does not fire.

Docs

N/A

@bholmesdev bholmesdev marked this pull request as ready for review May 21, 2024 14:52
Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: 9a86ad1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 21, 2024
@bholmesdev bholmesdev merged commit a5d79dd into main May 21, 2024
13 checks passed
@bholmesdev bholmesdev deleted the fix/actions-header-warning branch May 21, 2024 16:36
@astrobot-houston astrobot-houston mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants