Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated esbuild #3028

Merged
merged 3 commits into from
Apr 10, 2022
Merged

chore: updated esbuild #3028

merged 3 commits into from
Apr 10, 2022

Conversation

JuanM04
Copy link
Contributor

@JuanM04 JuanM04 commented Apr 7, 2022

Changes

Update esbuild to its latest version (0.14.25 --> ^0.14.32). Also, our lockfile updates will install patch version automatically

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2022

🦋 Changeset detected

Latest commit: 9dcdc98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
astro Patch
@astrojs/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 7, 2022
@matthewp
Copy link
Contributor

matthewp commented Apr 7, 2022

I think this is ok, just want to check if we pinned of a reason, cc @FredKSchott @natemoo-re

@natemoo-re
Copy link
Member

natemoo-re commented Apr 8, 2022

@matthewp not that I can remember. Maybe an issue introduced in a patch version that has since been fixed?

@FredKSchott
Copy link
Member

iirc it MIGHT have been that certain hashes changed across versions, which made it hard to keep snapshot tests in sync. But, it looks like tests are still passing. I'm not sure.

It may have been that we were trying to match Vite or Snowpack's internal version? But they're now on "esbuild": "^0.14.27" so that's no longer accurate either.

If anyone has time to git blame that would be great, but otherwise the fact that this update was painless kind of proves that it's not completely unsafe.

@JuanM04
Copy link
Contributor Author

JuanM04 commented Apr 9, 2022

The last update was made by @FredKSchott: #2750

@FredKSchott
Copy link
Member

LGTM!

@FredKSchott FredKSchott merged commit 982f64f into main Apr 10, 2022
@github-actions github-actions bot mentioned this pull request Apr 10, 2022
@JuanM04 JuanM04 deleted the chore/esbuild-up branch April 10, 2022 21:41
@github-actions github-actions bot mentioned this pull request Apr 11, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* chore: updated esbuild

* Changeset
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* chore: updated esbuild

* Changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants