Refactor @astrojs/prism, fix Prism component import not working #4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ac6d609 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
matthewp
reviewed
Aug 1, 2022
|
Missing a changeset. |
matthewp
reviewed
Aug 2, 2022
natemoo-re
approved these changes
Aug 2, 2022
| import Prism from 'prismjs'; | ||
| import { addAstro } from './internal.mjs'; | ||
| import loadLanguages from 'prismjs/components/index.js'; | ||
| import { runHighlighterWithAstro } from './dist/highlighter'; |
There was a problem hiding this comment.
While we're at it, is there a place that makes more sense than packages/astro-prism? I think that's leftover from when the package was literally named astro-prism. Maybe just packages/prism?
matthewp
approved these changes
Aug 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
runHighlightto itmarkdown-remarkand@astrojs/mdxThis makes the dependency of
@astrojs/prismmuch clearer, previously a lot of packages independently depended on eitherprismjsor@astrojs/prism. Now all the packages who needs it depend on@astrojs/prism(who itself, obviously depends onprismjs)Testing
Tests still pass
Docs
N/A