Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astro.cookies implementation #4876

Merged
merged 5 commits into from
Sep 28, 2022
Merged

Astro.cookies implementation #4876

merged 5 commits into from
Sep 28, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Sep 26, 2022

Changes

Testing

  • Unit tests added to cover the Astro.cookies API surface
  • Fixture tests added to test integration within Astro.

Docs

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2022

🦋 Changeset detected

Latest commit: 43df66a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Sep 26, 2022
@matthewp
Copy link
Contributor Author

This will fix #4834

@github-actions github-actions bot added the semver: minor Change triggers a `minor` release label Sep 27, 2022
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@matthewp matthewp marked this pull request as ready for review September 27, 2022 20:37
@matthewp matthewp requested a review from a team as a code owner September 27, 2022 20:37
@sarah11918
Copy link
Member

Hi @matthewp - we've taken a look at this for Docs and the inline docs you've written here wouldn't end up on the docs page. As this PR stands, this would mean nothing ends up in Docs. So, nothing holds this PR up, but we would want an accompanying Docs PR to the API reference page so that when the release goes out, there's at least something minimal there corresponding to the new feature in the changelog.

I think we would want to take what you've got in the RFC and split that content up into an entry for the API reference page and... some other page? Can we figure out what's the minimum that needs to go on API reference, consistent with the other entries there, and get that ready to merge with this PR in a Docs PR? Then, we can take the rest of the great content in the RFC and figure out a place for it.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing in this PR that docs needs to review, but we've requested a Docs PR in another comment!

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @matthewp! Like Sarah, I think a summary of the API in the API Reference (maybe after Astro.response?) would be a good start.

Additional good spots for docs:

packages/astro/src/core/cookies/cookies.ts Show resolved Hide resolved
packages/astro/src/core/cookies/cookies.ts Show resolved Hide resolved
packages/astro/src/core/cookies/cookies.ts Show resolved Hide resolved
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants