-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astro.cookies implementation #4876
Conversation
🦋 Changeset detectedLatest commit: 43df66a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This will fix #4834 |
e9a03e0
to
d3ce462
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
Hi @matthewp - we've taken a look at this for Docs and the inline docs you've written here wouldn't end up on the docs page. As this PR stands, this would mean nothing ends up in Docs. So, nothing holds this PR up, but we would want an accompanying Docs PR to the API reference page so that when the release goes out, there's at least something minimal there corresponding to the new feature in the changelog. I think we would want to take what you've got in the RFC and split that content up into an entry for the API reference page and... some other page? Can we figure out what's the minimum that needs to go on API reference, consistent with the other entries there, and get that ready to merge with this PR in a Docs PR? Then, we can take the rest of the great content in the RFC and figure out a place for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing in this PR that docs needs to review, but we've requested a Docs PR in another comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @matthewp! Like Sarah, I think a summary of the API in the API Reference (maybe after Astro.response
?) would be a good start.
Additional good spots for docs:
- SSR features: https://docs.astro.build/en/guides/server-side-rendering/#features
- Our upcoming endpoints guide that @Jutanium is working on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests!
515690c
to
43df66a
Compare
Today is minor release day!
Changes
Testing
Docs