Support solidjs libraries #5059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d8994c5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
matthewp
reviewed
Oct 12, 2022
matthewp
reviewed
Oct 12, 2022
| } | ||
| const require = createRequire(pkgPath); | ||
| const pkg = JSON.parse(fs.readFileSync(pkgPath, 'utf-8')); | ||
| const deps = [...Object.keys(pkg.dependencies || {}), ...Object.keys(pkg.devDependencies || {})]; |
There was a problem hiding this comment.
should this include peerDependencies?
There was a problem hiding this comment.
This part scans for the root project package.json, so I'm not sure if peerDependencies would make sense here 🤔
matthewp
approved these changes
Oct 12, 2022
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #4871
ssr.noExternalsame as vite-plugin-solid__astro_tag_component__in node_modules, since it importsastro/server/index.jsin node_modules (doesn't work in pnpm). This PR pre-resolveastro/server/index.jsto an absolute path.Testing
Added
@solidjs/routerto test, which previously would error the app entirely.Docs
Not sure if we should document the
noExternalbehaviour, it might be an implementation detail we want to hide.