-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vercel): includeFiles
and excludeFiles
#5085
Conversation
🦋 Changeset detectedLatest commit: 3f943d6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Is there an example case where this happens 🤔 I thought files that should be included but not bundled would be in the public directory. |
@bluwy Yes! https://discord.com/channels/830184174198718474/961342615805108326/1030221907276087326 Not only that, Vercel has this option in their vercel.json because it's a common issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These config options look helpful @JuanM04! I just took a shot at trying to unify the wording between the two, for consistency. See what you think!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
!preview include-files |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this, but the changes looks good 👍
!preview include-files |
|
Changes
Added options to forcefully include or exclude files from the Function. This will help mitigate lots of "missing file" problems
Edit: as a side-effect, it also fixes the output folder of the Edge adapter, which was broken in v2.2.0
Testing
Docs