Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy compiler error handling #5855

Merged
merged 6 commits into from
Jan 18, 2023

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Jan 13, 2023

Changes

Testing

N/A, untested code path

Docs

Refactor only

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2023

🦋 Changeset detected

Latest commit: 54ee2e3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@natemoo-re natemoo-re changed the title Remove legacy compiler handling Remove legacy compiler error handling Jan 13, 2023
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 13, 2023
@natemoo-re
Copy link
Member Author

Actually, we might want to hang on to this, but the error is pretty inscrutable at the moment. Going to refactor this to use the new error overlay info.

This issue still repros and throws the error withastro/compiler#553

@natemoo-re natemoo-re requested a review from a team as a code owner January 15, 2023 20:24
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astro Docs approves this message!

@natemoo-re natemoo-re self-assigned this Jan 17, 2023
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
@natemoo-re natemoo-re merged commit 16dc36a into main Jan 18, 2023
@natemoo-re natemoo-re deleted the refactor/remove-compiler-error-handling branch January 18, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Compiler error links invalid due to issue forms
5 participants