Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused exports #5862

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Remove unused exports #5862

merged 1 commit into from
Jan 17, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 14, 2023

Changes

I noticed that ./vite-plugin-markdown-legacy and ./vite-plugin-markdown-legacy/* doesn't map to anything now that the feature is removed in Astro 2.0, so I removed them. (Thanks publint 🙂)

I also noticed that several Vite plugin exports aren't used (?) So I removed them as well.

I think there's more we can remove to clean things up, but starting with a small subset first that I'm confident with.

Testing

Existing tests should pass.

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2023

🦋 Changeset detected

Latest commit: c2a3293

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 14, 2023
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't think those exports are used, so LGTM 😄

@bluwy bluwy merged commit 1ca81c1 into main Jan 17, 2023
@bluwy bluwy deleted the remove-exports branch January 17, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants