[create-astro] Execute the 'git' step as the final interaction #6314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the initialized repository has all configuration changes commited in the first commit
🦋 Changeset detectedLatest commit: 0757186 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: create-astro
natemoo-re
approved these changes
Feb 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the initialized repository has all configuration changes commited in the first commit
Changes
Changes the order of the
create-astrointeractive steps. Previously, it would rungit init,git add,git commitbefore prompting for which tsconfig schema the project would use. Ifstrictorstrictestare selected, this would mean thattsconfig.jsonwould then be modified, and the initial repo is dirty.Testing
pnpm install && pnpm build && pnpm test: All (47) tests passed.
There could likely be an additional test for this, though I'm not entirely sure how to start writing tests for this ATM.
Docs
Docs should not be needed.
Only affects ordering of the interactive script. Anyone using create-astro programmatically should be using the CLI --flags