Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for non-printable chars to CLI #6682

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

andremralves
Copy link
Contributor

Changes

fixes #6609

Add a validation, when you set your project's name, that verifies if there is any non-printable characters in the input buffer.

  • Just a regex that matches any non-printable character from ASCII table like Ctrl characters.

Peek 2023-03-27 20-35

  • Is this response message good? I'm accepting suggestions.

Testing

No, I didn't find a way to test the validation that comes from the prompt.

Docs

No docs necessary.

@changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2023

🦋 Changeset detected

Latest commit: 8f96946

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Mar 27, 2023
@andremralves andremralves changed the title Add validation for non-printable chars in CLI Add validation for non-printable chars to CLI Mar 28, 2023
@matthewp matthewp merged commit 3356023 into withastro:main Apr 12, 2023
@astrobot-houston astrobot-houston mentioned this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm create astro@latest directory creation captures Ctrl-W "cut word" shortcut as control character
2 participants