Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lit integration nested component rendering #6752

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Fix lit integration nested component rendering #6752

merged 3 commits into from
Apr 5, 2023

Conversation

augustjk
Copy link
Contributor

@augustjk augustjk commented Apr 4, 2023

Changes

Provides a renderInfo object to renderShadow to properly handle nested component rendering.
Fixes #6743

Testing

Added a case for it in the mocha test.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2023

🦋 Changeset detected

Latest commit: 580ffe1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) labels Apr 4, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test!

@matthewp matthewp merged commit c7eb0d4 into withastro:main Apr 5, 2023
@astrobot-houston astrobot-houston mentioned this pull request Apr 5, 2023
@augustjk augustjk deleted the fix-lit-plugin-nested-components branch April 5, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lit nested components results in error
3 participants