Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render 404 page content for existing pages with 404 Response #7143

Merged
merged 1 commit into from
May 22, 2023
Merged

Render 404 page content for existing pages with 404 Response #7143

merged 1 commit into from
May 22, 2023

Conversation

johannesspohr
Copy link
Contributor

Changes

  • Currently, a 404 response doesn't render any content
  • With this change, it will render the 404 page, the same fashion it also renders the 500 page

Testing

  • Added a test case to the ssr error pages test

Docs

Changeset is added

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2023

🦋 Changeset detected

Latest commit: 70c6800

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 19, 2023
@matthewp matthewp merged commit b41963b into withastro:main May 22, 2023
@astrobot-houston astrobot-houston mentioned this pull request May 22, 2023
Merged
@arty-name
Copy link
Contributor

arty-name commented May 23, 2023 •
edited
Loading

Should I create an issue if this doesn’t work with node adapter in the dev mode?

@arty-name arty-name mentioned this pull request May 23, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johannesspohr @arty-name @matthewp