Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deno adapter #8559

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Remove the deno adapter #8559

merged 1 commit into from
Sep 27, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Sep 14, 2023

Changes

Testing

N/A

Docs

N/A

@matthewp matthewp requested a review from a team as a code owner September 14, 2023 15:08
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

⚠️ No Changeset found

Latest commit: 2008ae4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 14, 2023
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A reminder that when we publish a new version (major presumably), we have to update the index file to throw an error with a message saying that the package is deprecated, and moved to the new org.

packages/integrations/deno/package.json Outdated Show resolved Hide resolved
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion below, and pointing people to our own docs page if they need to remove/migrated.

packages/integrations/deno/README.md Outdated Show resolved Hide resolved
@matthewp matthewp merged commit 87d5b84 into main Sep 27, 2023
13 checks passed
@matthewp matthewp deleted the remove-deno branch September 27, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants