-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent bumping peer deps #8893
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yikes, good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will bite us when we are going to do another major release, and the ranges aren't automatically updated. So if you want to go ahead, we must update our internal documentation and remind us that this is a manual step. Why not use workspace:^3.0.0
?
I'll update the internal docs 👍 |
@ematipico looks like with the |
Changes
The integrations'
astro
peer dep ranges has been updating, which is a breaking change. I changed it to an explicit version range instead ofworkspace:
so changeset doesn't bump it now. Works especially in combination ofthe onlyUpdatePeerDependentsWhenOutOfRange
experimental option.The peer dep ranges are all reset to
"astro": "^3.0.0"
Testing
Ran
pnpm changeset version
locally.Docs
n/a.