Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-astro): respect existing package.json#scripts #8911

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

natemoo-re
Copy link
Member

Changes

Testing

Test added. Fixture was updated to verify that this case is handled.

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: 89aef12

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: create-astro Related to the `create-astro` package (scope) docs pr A PR that includes documentation for review labels Oct 24, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick work @natemoo-re 🚀

Copy link
Contributor

@lilnasy lilnasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! The tests are probably going to be a lifesaver down the line.

@natemoo-re natemoo-re merged commit b236d88 into main Oct 24, 2023
13 checks passed
@natemoo-re natemoo-re deleted the fix/create-astro-scripts branch October 24, 2023 18:48
@astrobot-houston astrobot-houston mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr A PR that includes documentation for review pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants