i18n(domains): validation and updated logic #9099

ematipico · 2023-11-14T16:11:18Z

Changes

This PR starts the work around domain support. Here are the changes:

updated the schema with proper validation for the domains configuration;
updated the Astro features with the domains support capability. I am not aware of any esoteric case, so notifying Astro with SupportKind should be enough
updated the getAsbsoluteLocaleUrl function, which now accepts domains and a isBuild flag. isBuild is required because we can only use the URLs with domains when building the website, otherwise the dev server is broken

Closes: PLT-994, PLT-992 and PLT-1206

Testing

I added various cases to test the implemented features

Docs

Added some basic documentation

changeset-bot · 2023-11-14T16:11:23Z

⚠️ No Changeset found

Latest commit: 2aaacb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

matthewp · 2023-11-14T18:15:22Z

packages/astro/src/i18n/vite-plugin-i18n.ts

 						...i18n,
 						...opts 
 					});

 					export const getRelativeLocaleUrlList = (path = "", opts) => _getLocaleRelativeUrlList({ 
 						base, path, trailingSlash, format, ...i18n, ...opts });
-					export const getAbsoluteLocaleUrlList = (path = "", opts) => _getLocaleAbsoluteUrlList({ base, path, trailingSlash, format, site, ...i18n, ...opts });
+					export const getAbsoluteLocaleUrlList = (path = "", opts) => _getLocaleAbsoluteUrlList({ 
+						base, path, trailingSlash, format, site, isBuild, ...i18n, ...opts 


looks like getAbsoluteLocaleUrlList has not changed but is now being passed isBuild, what is this flag used for?

I addressed your comment. Very silly from me, good catch.

isBuild, what is this flag used for?

From the PR description:

updated the getAsbsoluteLocaleUrl function, which now accepts domains and a isBuild flag. isBuild is required because we can only use the URLs with domains when building the website, otherwise the dev server is broken

matthewp · 2023-11-14T21:22:41Z

Needs a changeset.

ematipico · 2023-11-14T21:28:20Z

Needs a changeset.

I will add the changeset at the end. The PR is against the feat/i18n-domain branch.

bluwy

One small nit, but looks good to me!

packages/astro/src/i18n/index.ts

* i18n(domains): validation and updated logic (#9099) * feat(i18n): domain with lookup table (#9112) * chore: add changelog, fix types and enable experimental support in node/vercel * rebase and update lock file * chore: fix failing test * Apply suggestions from code review Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Matthew Phillips <matthew@skypack.dev> * Update .changeset/tidy-carrots-jump.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * wip * chore: rebase, conflicts and tests * update lock file * chore: correct configuration * chore: correct configuration * fix: regressions * chore: fix conflicts and add more tests * chore: add more validation * chore: more tests and add more restrictions * fix changeset * change and revert adapters * add another restriction * lock file update * Update packages/astro/src/@types/astro.ts Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * Update packages/astro/src/@types/astro.ts Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> * wat * fix syntax error * fix config example * Fix for #9673 (#9680) * Fix for #9673 * 🦋 add changeset file * Update breezy-plants-smoke.md Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev> * ⚡️ simplified normalizeConfigPath --------- Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev> * Fix env var replacement for export const prerender (#9807) * feat(alpinejs): allow customizing the Alpine instance (#9751) * feat(alpinejs): allows customzing the Alpine instance * chore: add e2e tests * fix: rename script * Update index.ts * fix: lockfile * [ci] format * chore: use correct lock file * chore: rebase * fix regressions in tests * fix regressions in tests * fix build * add description * fix missing types * chore: fix tests, again :D * eslint * Update packages/astro/src/@types/astro.ts Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com> * chore: address feedback * chore: fix regressions * chore: refactor naming * Update packages/astro/src/core/app/index.ts Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> * chore: address feedback * update lock file * chore: infer routing from options, not strategy * merge from main * merge from main * Experimental support in vercel adapter * Update packages/astro/src/@types/astro.ts Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * Update packages/astro/src/@types/astro.ts Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * Update .changeset/tidy-carrots-jump.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * better changesets * Updates both experimental.i18nDomains and i18ndomains for experimental strategy * fix link syntax * consistent tabs/spaces * Update packages/astro/src/@types/astro.ts Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * apply suggestion --------- Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Matthew Phillips <matthew@skypack.dev> Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> Co-authored-by: Lou Cyx <git@lou.cx> Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev> Co-authored-by: Florian Lefebvre <ematipico@users.noreply.github.com> Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>

ematipico added 5 commits November 13, 2023 16:55

feat(i18n): add i18n to feature map

b89c770

feat: domains

760a20d

i18n(domains): validation and updated logic

ed6bfbb

add cases for integration tests

4f0b5ab

updated the docs

890d91b

github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Nov 14, 2023

ematipico force-pushed the feat/domain-feature-map branch from 4a058fd to 890d91b Compare November 14, 2023 16:15

fix build issue

94e2672

matthewp reviewed Nov 14, 2023

View reviewed changes

ematipico added 2 commits November 14, 2023 14:54

chore: apply fixes

16943b6

chore: catch error

ac9b54d

bluwy approved these changes Nov 15, 2023

View reviewed changes

packages/astro/src/i18n/index.ts Outdated Show resolved Hide resolved

chore: apply suggestion

2aaacb8

ematipico merged commit 33dffdb into feat/i18n-domain Nov 15, 2023
5 checks passed

ematipico deleted the feat/domain-feature-map branch November 15, 2023 13:58

sarah11918 mentioned this pull request Nov 16, 2023

feat(i18n): domain with lookup table #9112

Merged

ematipico added a commit that referenced this pull request Nov 20, 2023

i18n(domains): validation and updated logic (#9099)

07d2f95

ematipico added a commit that referenced this pull request Nov 21, 2023

i18n(domains): validation and updated logic (#9099)

5f7f011

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

i18n(domains): validation and updated logic #9099

i18n(domains): validation and updated logic #9099

ematipico commented Nov 14, 2023 •

edited

Loading

changeset-bot bot commented Nov 14, 2023 •

edited

Loading

matthewp Nov 14, 2023

ematipico Nov 14, 2023

matthewp commented Nov 14, 2023

ematipico commented Nov 14, 2023 •

edited

Loading

bluwy left a comment

i18n(domains): validation and updated logic #9099

i18n(domains): validation and updated logic #9099

Conversation

ematipico commented Nov 14, 2023 • edited Loading

Changes

Testing

Docs

changeset-bot bot commented Nov 14, 2023 • edited Loading

⚠️ No Changeset found

matthewp Nov 14, 2023

Choose a reason for hiding this comment

ematipico Nov 14, 2023

Choose a reason for hiding this comment

matthewp commented Nov 14, 2023

ematipico commented Nov 14, 2023 • edited Loading

bluwy left a comment

Choose a reason for hiding this comment

ematipico commented Nov 14, 2023 •

edited

Loading

changeset-bot bot commented Nov 14, 2023 •

edited

Loading

ematipico commented Nov 14, 2023 •

edited

Loading