Filter out Svelte's unknown data prop warnings #9510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes withastro#9508 The existing console filter looked for class attributes. This change adds a check for warnings related to data attributes as well.
🦋 Changeset detectedLatest commit: ace47d4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: svelte
github-actions
bot
added
the
pr: docs
bluwy
reviewed
Dec 26, 2023
Switch from string.indexOf to string.includes.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this change?
Fixes Svelte island does not expect unknown props, causes warning #9508
Be short and concise. Bullet points can help!
The existing console filter looked for class attributes. This change adds a check for warnings related to data attributes as well.
pnpm exec changesetTesting
Tested by validating the change in a simple Astro app with a Svelte counter component.
Before the fix, the console output contains the following warning:
After patching client.js in node_modules and clearing the cache:
Run the app again
The console output is now clear, without any warnings.
Docs
N/A - no docs need to be updated. This only removes console warnings, which was already happening automatically.