Reduce work done by astro sync

[lilnasy]

Changes

• Closes Malformed entry filename is not reported #9711

Testing

Does not affect behavior. Existing tests should pass.

Docs

Does not affect usage.

[changeset-bot]

🦋 Changeset detected

Latest commit: 2b24054

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[sarah11918]

Assuming that this now also says which file doesn't satisfy the content collections type, I'd say that's an improvement! The only way it could be better is if it identified the specific way in which the file did not conform.

[matthewp]

lgtm

[florian-lefebvre]

I guess we need a changeset?

[lilnasy]

Assuming that this now also says which file doesn't satisfy the content collections type, I'd say that's an improvement! The only way it could be better is if it identified the specific way in which the file did not conform.

Apparently it already does, but only during build.

[Princesseuh]

Assuming that this now also says which file doesn't satisfy the content collections type, I'd say that's an improvement! The only way it could be better is if it identified the specific way in which the file did not conform.

Apparently it already does, but only during build.

Those are essentially two different errors, one is because it couldn't generate the types at all (entry malformed), whereas the other one is that a type didn't match

[lilnasy]

Those are essentially two different errors, one is because it couldn't generate the types at all (entry malformed), whereas the other one is that a type didn't match.

I would've expected it to validate if it parses the content entries. Maybe the odd part is the fact that astro sync reads the markdown files in the first place.

[natemoo-re]

I would've expected it to validate if it parses the content entries. Maybe the odd part is the fact that astro sync reads the markdown files in the first place.

Honestly that is surprising. I don't think anything about sync needs to perform eager validation, but that could be a follow-up task to fix.

[natemoo-re]

#NWTWWHB

[lilnasy]

Sorry for stealing all the reviews, but I think we can not even error in the first place.

[lilnasy]

This is annoying, build depends on sync via shared global state.

pr was redone

pr was redone

[Princesseuh]

All of the astro x commands run astro sync at their start, so I assume this is true for many commands

[lilnasy]

That makes sense. I should clarify what I found problematic working on this.

build depends not just on the functionality of sync, but also on it being performed in the same way npm exec astro sync would have. It involves starting its own vite server,
doing it in the same process, and mutating imported global state so build can consume the result.

The result is errors appearing from unexpected places, and tracking them down being a guessing game.

[lilnasy]

I did not feel good about the enhacing GenerateContentTypesError because it is a catch-all error. It does not make sense for it to report a specific file name.

The solution I want is where a new AstroError wraps the YamlException close to where it is thrown. That can be in a new PR.