Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial: Change theme toggle from div to button #2616

Merged
merged 1 commit into from
Feb 12, 2023
Merged

Conversation

Jutanium
Copy link
Contributor

@Jutanium Jutanium commented Feb 9, 2023

What kind of changes does this PR include?

  • New or updated content

Description

@netlify
Copy link

netlify bot commented Feb 9, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit c982687
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63e544fdd59b310008207daa
😎 Deploy Preview https://deploy-preview-2616--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918
Copy link
Member

Thanks for grabbing this issue, @Jutanium! Will ask @delucis to confirm this change, and reminder that a change here means a change to https://github.com/withastro/blog-tutorial-demo ... AND in the content-collections branch. 😅 I made an issue to track this: withastro/blog-tutorial-demo#4

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesssss!

@Jutanium Jutanium merged commit 8cff437 into main Feb 12, 2023
@Jutanium Jutanium deleted the tutorial-button branch February 12, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suboptimal blog theme toggler
4 participants