-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature directories to project structure guide #3237
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Good call, @TheOtterlord! I'm wondering what we should call these directories. We might refer to them as "reserved" directories internally (as opposed to "feature" directories) because that also conveys that you can't have these folders yourself for other things... they really are reserved in Astro. |
Also, I'd be tempted to put these up with the other folders, and just say in each folder that it's reserved, vs a special section, I think? Just a first thought. |
Yep! I like that. I struggled between "Reserved" and "Features" because I don't think |
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @TheOtterlord! I've made some suggestions here, and again, I think we should move these up to where the other folders are explained. I don't think this should be a separate category, but rather, these folders should occur in alphabetical order on the page.
So, I would put src/assets/
right after src/
and I would put src/content/
after src/components/
. Leave each folder itself to describe what it does, whether it's reserved etc.
I'm not sure why a bunch of checks are failing (could be a fluke!) but let's get this content in the right spot, then figure that out! 😄
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Seems the CI fixed itself :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great now, I think! The src/assets/
content was just moved a little too high up, so I brought it back down. And, I threw the word "reserved" into src/content/
, but I think with these changes, we're good to go! 🙌
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
D'oh! I realized that while I ALWAYS refer to folders with a trailing slash... none of the other sidebar entries do. 😅 So, I'll just quickly revert those for consistency, then I'll get you in the "update branch" queue and merged! 🎉 |
What kind of changes does this PR include?
Description
src/content/
to project structure guide #2797src/content
&src/assets