-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n overhaul #365
Merged
Merged
i18n overhaul #365
Commits on Apr 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 91a0a7b - Browse repository at this point
Copy the full SHA 91a0a7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 962bf01 - Browse repository at this point
Copy the full SHA 962bf01View commit details
Commits on Apr 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5136a75 - Browse repository at this point
Copy the full SHA 5136a75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 591a10b - Browse repository at this point
Copy the full SHA 591a10bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd1999c - Browse repository at this point
Copy the full SHA fd1999cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0670922 - Browse repository at this point
Copy the full SHA 0670922View commit details -
Configuration menu - View commit details
-
Copy full SHA for d893e32 - Browse repository at this point
Copy the full SHA d893e32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0aa6346 - Browse repository at this point
Copy the full SHA 0aa6346View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09e3ad8 - Browse repository at this point
Copy the full SHA 09e3ad8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28592d5 - Browse repository at this point
Copy the full SHA 28592d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae276e4 - Browse repository at this point
Copy the full SHA ae276e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebc9bdd - Browse repository at this point
Copy the full SHA ebc9bddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 796d1f8 - Browse repository at this point
Copy the full SHA 796d1f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e6c968 - Browse repository at this point
Copy the full SHA 1e6c968View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f18ca4 - Browse repository at this point
Copy the full SHA 9f18ca4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5112864 - Browse repository at this point
Copy the full SHA 5112864View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3898be3 - Browse repository at this point
Copy the full SHA 3898be3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1de5c0 - Browse repository at this point
Copy the full SHA f1de5c0View commit details
Commits on Apr 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7ff1691 - Browse repository at this point
Copy the full SHA 7ff1691View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffd5819 - Browse repository at this point
Copy the full SHA ffd5819View commit details -
Configuration menu - View commit details
-
Copy full SHA for 803dd6a - Browse repository at this point
Copy the full SHA 803dd6aView commit details -
Stop supporting localized slugs
Decision made based on this high tech, large sample size polling data: https://discord.com/channels/830184174198718474/867764597838184478/966981090831126559
Configuration menu - View commit details
-
Copy full SHA for d1b474d - Browse repository at this point
Copy the full SHA d1b474dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fc604d - Browse repository at this point
Copy the full SHA 4fc604dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d7741a4 - Browse repository at this point
Copy the full SHA d7741a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 424033a - Browse repository at this point
Copy the full SHA 424033aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 139b8e7 - Browse repository at this point
Copy the full SHA 139b8e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6f1510 - Browse repository at this point
Copy the full SHA d6f1510View commit details -
Refactor fallback content generation
Relies only on the existence of `.md` files to decide how to generate fallback pages rather than relying on the navigation contents as previously. This is possible now that slugs are consistent across locales and helps for cases where a nav link isn’t for an actual page (“Installation” currently hits a redirect route for example).
Configuration menu - View commit details
-
Copy full SHA for b21eb10 - Browse repository at this point
Copy the full SHA b21eb10View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1ddc87 - Browse repository at this point
Copy the full SHA f1ddc87View commit details
Commits on Apr 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for db7377a - Browse repository at this point
Copy the full SHA db7377aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc79ee1 - Browse repository at this point
Copy the full SHA dc79ee1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4edca6d - Browse repository at this point
Copy the full SHA 4edca6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31507db - Browse repository at this point
Copy the full SHA 31507dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5fb3a8 - Browse repository at this point
Copy the full SHA d5fb3a8View commit details -
Upgrade Astro to 1.0.0-beta.17
Brings in some fixes for Markdown Content component
Configuration menu - View commit details
-
Copy full SHA for 6512da9 - Browse repository at this point
Copy the full SHA 6512da9View commit details -
Don’t pass
Content
component through propsSomething about how components are rendered goes wrong on build (not during dev) if we pass `Content` out of `getStaticProps` via props. Explicitly globbing the content again inside the page itself seems to fix this 🤷
Configuration menu - View commit details
-
Copy full SHA for 98ed9e2 - Browse repository at this point
Copy the full SHA 98ed9e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f11662 - Browse repository at this point
Copy the full SHA 5f11662View commit details -
Configuration menu - View commit details
-
Copy full SHA for 485a178 - Browse repository at this point
Copy the full SHA 485a178View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80b2e28 - Browse repository at this point
Copy the full SHA 80b2e28View commit details
Commits on Apr 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3f0eb01 - Browse repository at this point
Copy the full SHA 3f0eb01View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1f595d - Browse repository at this point
Copy the full SHA b1f595dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1e05c2 - Browse repository at this point
Copy the full SHA c1e05c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e92683 - Browse repository at this point
Copy the full SHA 6e92683View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d495ed - Browse repository at this point
Copy the full SHA 3d495edView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc93d1b - Browse repository at this point
Copy the full SHA bc93d1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1283d89 - Browse repository at this point
Copy the full SHA 1283d89View commit details -
Configuration menu - View commit details
-
Copy full SHA for bcac7b6 - Browse repository at this point
Copy the full SHA bcac7b6View commit details
Commits on Apr 25, 2022
-
perf: Avoid globbing all Markdown files
We tag navigation sidebar entries as “fallback” content based on if the slug exists for a given language. Previously I did this using Vite’s `import.meta.glob('../pages/**/*.md)` to grab the URLs of all pages. Although this shouldn’t load content (you need `globEager` for that), this still seemed to trigger Astro processing *all* Markdown pages. Unsurprisingly, this was slow — HMR of ~10s for a single page edit 😬 I’ve replaced the glob by recursively reading the pages directory when needed using `fs.readdir`. Avoiding globbing also means we can target *only* the relevant language instead of all pages. That brings reloads back down to 100–200ms in dev. There is a disadvantage: if new pages are added while running `dev`, the navbar may be cached for previously visited pages and because we’re not using `glob`, Vite/Astro don’t know we’re depending on files, so won’t invalidate that cache. Not sure if there’s a workaround? But still, this solution seems preferable to waiting 10 seconds each time you make an edit.
Configuration menu - View commit details
-
Copy full SHA for adb545d - Browse repository at this point
Copy the full SHA adb545dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9f60bb - Browse repository at this point
Copy the full SHA b9f60bbView commit details
Commits on Apr 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ff252d9 - Browse repository at this point
Copy the full SHA ff252d9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.