Improve handling of RTL languages #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stores each language’s writing direction in the languages file to avoid needing to specify it in Markdown frontmatter as Arabic has done up until now. This also allows us to layout RTL-language pages correctly even when they contain LTR fallback content. After #365 the site navigation was on the right on the Arabic “Getting Started” page, but on the left for fallback pages. Making this a per-language and not a per-page setting makes this consistent. This commit also updates the `add-language` script to collect writing direction.
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
sarah11918
added
i18n
|
Closing this as it complicates our languages dictionary and won't be needed for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stores each language’s writing direction in
src/i18n/languages.tsto avoid needing to specify it in Markdown frontmatter (which is what Arabic has done up until now).This allows us to layout RTL-language pages correctly even when they contain LTR fallback content. After #365 the site navigation was on the right on the Arabic “Getting Started” page as expected, but on the left for fallback pages. Making this a per-language and not a per-page setting makes this consistent.
Just to demonstrate what this fixes, here are two Arabic pages as they render currently:
This commit also updates the
add-languagescript to collect writing direction.