Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en] Fixed several issues in code on the Astro container reference page #8378

Merged
merged 65 commits into from
May 23, 2024
Merged

Conversation

SnowDingo
Copy link
Contributor

Description (required)

As mentioned during the "Talking and Doc'ing", there was a very small issue in the example code on the container-reference page. This PR fixes this mistake and makes the example code work.
Before:
image

After:
New version

Related issues & labels (optional)

  • Closes: Issue addressed in the Astro Discord Community.
  • Suggested label: #Docs, #SmallFix, #English

By @SnowDingo, Discord: Snowdingo

SnowDingo and others added 30 commits February 11, 2024 20:36
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Ming-jun Lu <40516784+mingjunlu@users.noreply.github.com>
Co-authored-by: Ming-jun Lu <40516784+mingjunlu@users.noreply.github.com>
Co-authored-by: Ming-jun Lu <40516784+mingjunlu@users.noreply.github.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
SnowDingo and others added 22 commits March 26, 2024 16:58
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
fixed some broken Link
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Updated the japanese translation to the 2e4895d
version.
Still in draft.
Reflected the change #7593.
Fixed issue in the example code. server => serverEntryPoint. client => clientEntrypoint.
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 23, 2024 0:52am

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What express service, @SnowDingo ! Thank you for jumping on this, and welcome to Team Docs! 🥳

@astrobot-houston
Copy link
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/container-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels May 23, 2024
@sarah11918 sarah11918 merged commit 9511f43 into withastro:main May 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants