-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(es): Correction of missing imports for the function 'translatePath' #8620
Conversation
Imports should have been added so that the "translatePath" function can be used.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I like being more verbose here, although if we're adding the imports, we should also add the statement defining translatePath
to complete the snippet, as it's not exported directly. I guess we could import the defaultLang
as the value to pass to useTranslatedPath
(it's only needed as it's a required typed param).
const translatePath = useTranslatedPath(defaultLang);
I've not made any code suggestions in GitHub because our translated pages source their content from the english versions, so any changes need to be made to the en
version of this file. We accept the english version first, then translated versions as separate PRs.
Hi @fabriciodev26 - Just a reminder that if you'd like to contribute this change, it must be made to the Please let us know if you're interested in making that change! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fabriciodev26, I'll block this PR from being merged till you make these changes in the English version of the page instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fabriciodev26! I think this needs a small change.
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
made change to match English version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you everyone! I've just gone ahead and committed the changes to match so this PR can be published and helping people!
Imports should have been added so that the "translatePath" function can be used.
Description
I have corrected the lack of required imports for the 'translatePath' function. This ensures that the code can correctly access and use the 'translatePath' function, thus improving the integrity and functionality of the project.