Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(es): Correction of missing imports for the function 'translatePath' #8620

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

fabriciodev26
Copy link
Contributor

Imports should have been added so that the "translatePath" function can be used.

Description

I have corrected the lack of required imports for the 'translatePath' function. This ensures that the code can correctly access and use the 'translatePath' function, thus improving the integrity and functionality of the project.

Imports should have been added so that the "translatePath" function can be used.
Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jul 8, 2024 11:07am

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 21, 2024
@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 21, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
es recipes/i18n.mdx Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I like being more verbose here, although if we're adding the imports, we should also add the statement defining translatePath to complete the snippet, as it's not exported directly. I guess we could import the defaultLang as the value to pass to useTranslatedPath (it's only needed as it's a required typed param).

const translatePath = useTranslatedPath(defaultLang);

I've not made any code suggestions in GitHub because our translated pages source their content from the english versions, so any changes need to be made to the en version of this file. We accept the english version first, then translated versions as separate PRs.

@sarah11918
Copy link
Member

Hi @fabriciodev26 - Just a reminder that if you'd like to contribute this change, it must be made to the /en/ version of the file! (not /es/)

Please let us know if you're interested in making that change! 🚀

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fabriciodev26, I'll block this PR from being merged till you make these changes in the English version of the page instead.

delucis
delucis previously requested changes Jul 5, 2024
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fabriciodev26! I think this needs a small change.

src/content/docs/es/recipes/i18n.mdx Outdated Show resolved Hide resolved
sarah11918 and others added 2 commits July 8, 2024 07:57
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@sarah11918 sarah11918 dismissed stale reviews from delucis and yanthomasdev July 8, 2024 10:58

made change to match English version

@sarah11918 sarah11918 changed the title Correction of missing imports for the function 'translatePath' i18n(es): Correction of missing imports for the function 'translatePath' Jul 8, 2024
@sarah11918 sarah11918 added the code snippet update Updates a code sample: typo, outdated code etc. label Jul 8, 2024
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you everyone! I've just gone ahead and committed the changes to match so this PR can be published and helping people!

@sarah11918 sarah11918 merged commit b9dc4a2 into withastro:main Jul 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code snippet update Updates a code sample: typo, outdated code etc. i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants