Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update reference docs [i18nIgnore] #9196

Closed
wants to merge 0 commits into from
Closed

Conversation

astrobot-houston
Copy link
Contributor

This PR is auto-generated by a nightly GitHub action to update the reference docs from source code in withastro/astro.

@astrobot-houston astrobot-houston added the ci Automated PRs created by CI, or PRs about automation - ask @delucis for help! label Aug 25, 2024
Copy link

netlify bot commented Aug 25, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 15e46f4
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66cda833acfe220008bd4c3d
😎 Deploy Preview https://deploy-preview-9196--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor Author

astrobot-houston commented Aug 25, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/configuration-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@ArmandPhilippot
Copy link
Contributor

@delucis This PR should not be merged!

A fix has been made on docs repo instead of astro (see #9188) but this fix is correct. Instead, the following PR withastro/astro#11814 should be approved/merged to avoid conflicts.

@yanthomasdev
Copy link
Member

🚨 READ THIS BEFORE CLICKING BIG GREEN "SQUASH AND MERGE" BUTTON 🚨

I am not sure if we can safely close this one, but if we end up needing to merge this, let's not forget to add i18nIgnore to the title.

@yanthomasdev yanthomasdev changed the title ci: update reference docs ci: update reference docs [i18nIgnore] Aug 26, 2024
yanthomasdev

This comment was marked as outdated.

@yanthomasdev yanthomasdev dismissed their stale review August 26, 2024 16:55

the force-push trolled me and made me think it applied the changes in core, oops

@sarah11918
Copy link
Member

Did anyone go fix this at core yet? 😄 No worries to keep this open, with [i18nIgnore]. Once the change at source is made, this PR should update with a whopping 0 lines changed.

We can either merge or just close at that time, but that will be our indication that the original change was in fact made properly.

If no one has made this change yet, I can take care of it either tonight or tomorrow! But, happy if someone else does, too!

@ArmandPhilippot
Copy link
Contributor

@sarah11918 The change in core is ready (see withastro/astro#11814), all that remains is to merge it!

@sarah11918
Copy link
Member

Wonderful, thank you! I haven't been in that repo for a few days, and I know the tests have been buggy, so probably no one wanted to merge while a test was failing there. I'll rerun the tests and we'll be good after it's merged! Thank you!

@sarah11918
Copy link
Member

And, this has successfully closed itself! 🥳

Thank you @eduardocereto and @ArmandPhilippot for taking care of this! I can't reopen this PR because the branch has been deleted... I would have merged the empty PR here and given you both credit. But, Eduardo, you'll show up in the Astro release notes with your patch! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Automated PRs created by CI, or PRs about automation - ask @delucis for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants