-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update reference docs [i18nIgnore] #9196
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
@delucis This PR should not be merged! A fix has been made on |
🚨 READ THIS BEFORE CLICKING BIG GREEN "SQUASH AND MERGE" BUTTON 🚨 I am not sure if we can safely close this one, but if we end up needing to merge this, let's not forget to add |
a0a7434
to
e476ef3
Compare
the force-push trolled me and made me think it applied the changes in core, oops
Did anyone go fix this at core yet? 😄 No worries to keep this open, with [i18nIgnore]. Once the change at source is made, this PR should update with a whopping 0 lines changed. We can either merge or just close at that time, but that will be our indication that the original change was in fact made properly. If no one has made this change yet, I can take care of it either tonight or tomorrow! But, happy if someone else does, too! |
@sarah11918 The change in core is ready (see withastro/astro#11814), all that remains is to merge it! |
Wonderful, thank you! I haven't been in that repo for a few days, and I know the tests have been buggy, so probably no one wanted to merge while a test was failing there. I'll rerun the tests and we'll be good after it's merged! Thank you! |
e476ef3
to
15e46f4
Compare
And, this has successfully closed itself! 🥳 Thank you @eduardocereto and @ArmandPhilippot for taking care of this! I can't reopen this PR because the branch has been deleted... I would have merged the empty PR here and given you both credit. But, Eduardo, you'll show up in the Astro release notes with your patch! 🙌 |
This PR is auto-generated by a nightly GitHub action to update the reference docs from source code in withastro/astro.