Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(ru): Fix typo in i18n.untranslatedContent #1243

Merged
merged 2 commits into from Dec 6, 2023
Merged

i18n(ru): Fix typo in i18n.untranslatedContent #1243

merged 2 commits into from Dec 6, 2023

Conversation

khajimatov
Copy link
Contributor

Description

This PR fixes small typo in packages/starlight/translations/ru.json file.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2023 •
edited

🦋 Changeset detected

Latest commit: d5dad36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 6, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Dec 6, 2023 6:39pm

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Dec 6, 2023
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

delucis
delucis reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Could you explain the difference here between “Этот” and “Это”? Online translations I’m checking all use “Этот”.

Also cc @Lootjs who added these translations originally — would love another pair of eyes on it!

@Lootjs
Copy link
Contributor

Lootjs commented Dec 6, 2023

Hey @delucis ! Originally, the line was not translated by me, here's the commit 660a5f5. Regarding the correct word, I agree with the author of the PR that it is more appropriate to use "Это" in this case 😊

@Lootjs
Copy link
Contributor

Lootjs commented Dec 6, 2023

Overall, it's hard to explain why we need to use exactly 'Это', but I'll try :) Every noun in Russian has a gender, and the word 'содержимое' is neutral. The word 'Это' is used for neutral nouns, and 'Этот' is for masculine ones. 🤓

delucis
delucis approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect — thanks so much for the explanation @Lootjs (and sorry I confused you for the original author, you did so much translation I guessed it was you 😄)

Thanks again for fixing @khajimatov 🎉

@Lootjs
Copy link
Contributor

Lootjs commented Dec 6, 2023

Nothing to worry about and always glad to help ♥️

@delucis delucis merged commit ee234eb into withastro:main Dec 6, 2023
8 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Dec 6, 2023
Merged
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Dec 13, 2023
@HiDeoo
Merge branch 'main' into hd-feat-tabs-sync
e22902b 
* main: (440 commits)
  i18n(fr): update `getting-started.mdx` (withastro#1245)
  [ci] format
  docs(showcase): add csmos.space (withastro#1269)
  [ci] format
  docs: add SiteOne Crawler to showcase (withastro#1264)
  Fix formatting
  [ci] format
  docs(i18n): Add Indonesian translation for site search documentation (withastro#1250)
  i18n(es): fix typo (withastro#1246)
  i18n(ja): Update getting-started.mdx (withastro#1252)
  i18n(es): Update `getting-started.mdx` (withastro#1247)
  i18n(ko-KR): update `getting-started.mdx` (withastro#1248)
  Update upgrade instructions to show new `@astrojs/upgrade` (withastro#1241)
  [ci] format
  [ci] release (withastro#1240)
  i18n(ru): Fix typo in `i18n.untranslatedContent` (withastro#1243)
  Fix timezone-reliance in LastUpdated (withastro#1170)
  Prefetch links on hover by default (withastro#1242)
  Add support for Astro v4, drop support for Astro v3 (withastro#1238)
  Add Matrix social icon (withastro#1203)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@khajimatov @astrobot-houston @Lootjs @delucis