Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(fr): update getting-started.mdx #1245

Merged
merged 3 commits into from
Dec 12, 2023
Merged

i18n(fr): update getting-started.mdx #1245

merged 3 commits into from
Dec 12, 2023

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Dec 6, 2023

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

This PR updates the french version of the getting-started.mdx page with the changes of #1241.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6c44fb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Dec 12, 2023 10:33pm

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Dec 6, 2023
dreyfus92
dreyfus92 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ÇMSB 🫡

@HiDeoo
Copy link
Member Author

HiDeoo commented Dec 7, 2023

After re-reading multiple times the original text for reviews, this started bothering me and decided to update the translation. I think the tiny change makes it way more closer to the original text and sounds better.

Altho, the spelling may now looks weird as this would usually be pronounced as "tout autres" but written as "tous autres" but after double checking, this is the correct spelling:

« Tout » devant « autre » est adjectif quand l’ensemble signifie « n’importe quel(le) ». Il est adverbe et invariable quand il signifie « tout à fait ».

Reference: https://www.question-orthographe.fr/question/tout-autres-ou-tous-autres/

ElianCodes
ElianCodes approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me!

@delucis delucis merged commit 7a3ca64 into withastro:main Dec 12, 2023
8 checks passed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Dec 13, 2023
@HiDeoo
Merge branch 'main' into hd-feat-tabs-sync
e22902b 
* main: (440 commits)
  i18n(fr): update `getting-started.mdx` (withastro#1245)
  [ci] format
  docs(showcase): add csmos.space (withastro#1269)
  [ci] format
  docs: add SiteOne Crawler to showcase (withastro#1264)
  Fix formatting
  [ci] format
  docs(i18n): Add Indonesian translation for site search documentation (withastro#1250)
  i18n(es): fix typo (withastro#1246)
  i18n(ja): Update getting-started.mdx (withastro#1252)
  i18n(es): Update `getting-started.mdx` (withastro#1247)
  i18n(ko-KR): update `getting-started.mdx` (withastro#1248)
  Update upgrade instructions to show new `@astrojs/upgrade` (withastro#1241)
  [ci] format
  [ci] release (withastro#1240)
  i18n(ru): Fix typo in `i18n.untranslatedContent` (withastro#1243)
  Fix timezone-reliance in LastUpdated (withastro#1170)
  Prefetch links on hover by default (withastro#1242)
  Add support for Astro v4, drop support for Astro v3 (withastro#1238)
  Add Matrix social icon (withastro#1203)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreyfus92 dreyfus92 dreyfus92 approved these changes

@ElianCodes ElianCodes ElianCodes approved these changes

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HiDeoo @delucis @ElianCodes @dreyfus92