Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Astro v4, drop support for Astro v3 #1238

Merged
merged 13 commits into from
Dec 6, 2023
Merged

Conversation

delucis
Copy link
Member

@delucis delucis commented Dec 6, 2023

Description

  • Closes Support for Astro v4 #1236
  • Updates Starlight’s dependencies to Astro v4 and updates integrations to match.
  • Drops support for Astro v3 — unfortunately necessary because of how we bundle MDX in Starlight. Before v1, it might be worth considering whether @astrojs/mdx should be a peer dependency we include in starter templates, but not directly as a dependency of @astrojs/starlight, so that we can avoid these situations.
  • WIP: next step is updating all remark/rehype-related dependencies. Done!

Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: 368fab0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Dec 6, 2023 3:38pm

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Dec 6, 2023
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Dec 6, 2023

size-limit report 📦

Path Size
/index.html 5.19 KB (+1.17% 🔺)
/_astro/*.js 20.47 KB (+0.78% 🔺)
/_astro/*.css 13.04 KB (0%)

@delucis delucis added the 🌟 minor Change that triggers a minor release label Dec 6, 2023
Copy link
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing!

Great work Chris!

Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@delucis delucis merged commit 02a808e into main Dec 6, 2023
8 checks passed
@delucis delucis deleted the chris/astro-v4 branch December 6, 2023 16:20
@astrobot-houston astrobot-houston mentioned this pull request Dec 6, 2023
@jeanlucaslima
Copy link

This is breaking the install command through the template. It will be fixed (I think) if there's a release with up to date library.

@delucis
Copy link
Member Author

delucis commented Dec 6, 2023

Yup! Just getting a release out any minute now — thanks for reporting 🙌

HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Dec 13, 2023
* main: (440 commits)
  i18n(fr): update `getting-started.mdx` (withastro#1245)
  [ci] format
  docs(showcase): add csmos.space (withastro#1269)
  [ci] format
  docs: add SiteOne Crawler to showcase (withastro#1264)
  Fix formatting
  [ci] format
  docs(i18n): Add Indonesian translation for site search documentation (withastro#1250)
  i18n(es): fix typo (withastro#1246)
  i18n(ja): Update getting-started.mdx (withastro#1252)
  i18n(es): Update `getting-started.mdx` (withastro#1247)
  i18n(ko-KR): update `getting-started.mdx` (withastro#1248)
  Update upgrade instructions to show new `@astrojs/upgrade` (withastro#1241)
  [ci] format
  [ci] release (withastro#1240)
  i18n(ru): Fix typo in `i18n.untranslatedContent` (withastro#1243)
  Fix timezone-reliance in LastUpdated (withastro#1170)
  Prefetch links on hover by default (withastro#1242)
  Add support for Astro v4, drop support for Astro v3 (withastro#1238)
  Add Matrix social icon (withastro#1203)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes 🌟 minor Change that triggers a minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Astro v4
5 participants