Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(i18n): Add Indonesian translation for site search documentation #1250

Merged
merged 6 commits into from
Dec 8, 2023
Merged

docs(i18n): Add Indonesian translation for site search documentation #1250

merged 6 commits into from
Dec 8, 2023

Conversation

herbras
Copy link
Contributor

@herbras herbras commented Dec 7, 2023

Description
What does this PR change? Give us a brief description.

Translate site-search.md docs into Indonesian.

@vercel Vercel
Copy link

vercel bot commented Dec 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Dec 8, 2023 3:26pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ff2d9bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Dec 7, 2023
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

HiDeoo
HiDeoo requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 🙌

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist.

I left a few comments and suggestions but these are pretty minor. Everything else looks great! 👍

docs/src/content/docs/id/guides/site-search.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/id/guides/site-search.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/id/guides/site-search.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/id/guides/site-search.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/id/guides/site-search.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/id/guides/site-search.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/id/guides/site-search.mdx Outdated Show resolved Hide resolved
HiDeoo
HiDeoo requested changes Dec 8, 2023
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick updates 🙌

I think there is 1 missing title left to be translated and then, we should be able to merge this new translation 🚀

docs/src/content/docs/id/guides/site-search.mdx Outdated Show resolved Hide resolved
HiDeoo
HiDeoo approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. Everything looks perfect now 🙌

@HiDeoo HiDeoo merged commit f4b672e into withastro:main Dec 8, 2023
8 checks passed
@HiDeoo HiDeoo mentioned this pull request Dec 8, 2023
Closed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Dec 13, 2023
@HiDeoo
Merge branch 'main' into hd-feat-tabs-sync
e22902b 
* main: (440 commits)
  i18n(fr): update `getting-started.mdx` (withastro#1245)
  [ci] format
  docs(showcase): add csmos.space (withastro#1269)
  [ci] format
  docs: add SiteOne Crawler to showcase (withastro#1264)
  Fix formatting
  [ci] format
  docs(i18n): Add Indonesian translation for site search documentation (withastro#1250)
  i18n(es): fix typo (withastro#1246)
  i18n(ja): Update getting-started.mdx (withastro#1252)
  i18n(es): Update `getting-started.mdx` (withastro#1247)
  i18n(ko-KR): update `getting-started.mdx` (withastro#1248)
  Update upgrade instructions to show new `@astrojs/upgrade` (withastro#1241)
  [ci] format
  [ci] release (withastro#1240)
  i18n(ru): Fix typo in `i18n.untranslatedContent` (withastro#1243)
  Fix timezone-reliance in LastUpdated (withastro#1170)
  Prefetch links on hover by default (withastro#1242)
  Add support for Astro v4, drop support for Astro v3 (withastro#1238)
  Add Matrix social icon (withastro#1203)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@herbras @astrobot-houston @HiDeoo