Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(es): Add translations for EC #1280

Merged
merged 5 commits into from
Dec 17, 2023
Merged

i18n(es): Add translations for EC #1280

merged 5 commits into from
Dec 17, 2023

Conversation

kevinzunigacuellar
Copy link
Member

Description

  • Adds spanish translations for Expressive Code

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: a198150

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Dec 17, 2023 6:19pm

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Dec 16, 2023
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Dec 16, 2023 •
edited
Loading

size-limit report 📦

Path Size
/index.html 5.21 KB (0%)
/_astro/*.js 21.42 KB (0%)
/_astro/*.css 13.04 KB (0%)

delucis
delucis approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinzunigacuellar — LGTM!

cc @hippotastic — is the intention for us to collect these here or would PRs for these preferably happen directly in the expressive-code repo so all Expressive Code users can benefit?

.changeset/old-adults-bake.md Outdated Show resolved Hide resolved
@delucis delucis added the 🌟 patch Change that triggers a patch release label Dec 17, 2023
@hippotastic
Copy link
Contributor

hippotastic commented Dec 17, 2023 •
edited
Loading

cc @hippotastic — is the intention for us to collect these here or would PRs for these preferably happen directly in the expressive-code repo so all Expressive Code users can benefit?

It's fine to let all translations happen here! I will wait for a couple of translations to accumulate and then take care of copying them over to EC. I don't currently have the bandwidth to take care of translation PRs in the EC repo, so I'm happy for them to be here. :)

@kevinzunigacuellar @delucis
Update .changeset/old-adults-bake.md
fe2a11b 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@kevinzunigacuellar @delucis
Update packages/starlight/translations/es.json
5850cf1 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
delucis
delucis approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Me parece bien! Gracias @kevinzunigacuellar 🙌

@delucis delucis merged commit 6b1693d into main Dec 17, 2023
8 checks passed
@delucis delucis deleted the ec-es-translation branch December 17, 2023 18:31
@astrobot-houston astrobot-houston mentioned this pull request Dec 17, 2023
Merged
@HiDeoo HiDeoo mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hippotastic hippotastic hippotastic left review comments

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinzunigacuellar @astrobot-houston @hippotastic @delucis