Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(pt-PT): add "environmental-impact" page #1561

Merged
merged 1 commit into from
Feb 28, 2024
Merged

i18n(pt-PT): add "environmental-impact" page #1561

merged 1 commit into from
Feb 28, 2024

Conversation

rgilsimoes
Copy link
Contributor

Description

  • Add new /docs/pt-pt/environmental-impact page in Portuguese (Portugal)

@vercel Vercel
Copy link

vercel bot commented Feb 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Feb 28, 2024 7:29am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 20aef43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 26, 2024
delucis
delucis requested changes Feb 27, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great — thank you @rgilsimoes!

Could you also add a pt-PT translation for the sidebar link here, please?

starlight/docs/astro.config.mjs

Line 138 in 235149d

'pt-BR': 'Impacto Ambiental',

The English text is “Environmental Impact”.

Fryuni
Fryuni approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@Fryuni Fryuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @rgilsimoes!

One tip though, we use squash merges and discard the commit messages, so you don't need to keep your own branch with super clean commits.

When you force-push GitHub discards in-progress reviews, including the review markers of what was already looked over, so even if you do want to rebase, organize, and rename your commits it is better to do that after the review iterations.

@rgilsimoes
Copy link
Contributor Author

Thank you for the tip. I was not aware of that.

delucis
delucis approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @rgilsimoes — and for reviewing @Fryuni 🙌

@delucis delucis merged commit 1d938c7 into withastro:main Feb 28, 2024
9 checks passed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Mar 2, 2024
@HiDeoo
Merge branch 'main' into hd-file-tree-docs
70fd3f6 
* main:
  [ci] format
  [ci] release (withastro#1574)
  Add `<Steps>` component (withastro#1564)
  Add `<FileTree>` component (withastro#1308)
  Add icon support to the `<TabItem>` component (withastro#1568)
  [ci] format
  docs: add Flojoy to showcase (withastro#1571)
  i18n(es): update `components` (withastro#1547)
  i18n(pt-PT): add "manual-setup" page (withastro#1570)
  i18n(zh-cn): Update pages.mdx (withastro#1565)
  Updates internal github actions to the latest versions (withastro#1569)
  [ci] format
  i18n(it): Update pages.mdx & plugins.mdx (withastro#1567)
  [ci] format
  i18n(pt-PT): add "environmental-impact" page (withastro#1561)
  [ci] format
  i18n(zh-cn): Update plugins.mdx (withastro#1566)
@rgilsimoes rgilsimoes deleted the i18n-ptPT-environmental-impact branch March 17, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

@Fryuni Fryuni Fryuni approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rgilsimoes @delucis @Fryuni